Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xtensa: mtk_mt8195_adsp: unify naming to mtk_mt8195_adsp #700

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

dcpleung
Copy link
Member

@dcpleung dcpleung commented Aug 30, 2023

This unifies various naming of mt8195 to mtk_mt8195_adsp which is of scheme xtensa-(vendor)_(soc name)-elf (except the QEMU cores). This renames the overlay directory, and updating both the config file and github workflows to match.

This unifies various naming of mt8195 to mtk_mt8195_adsp
which is of scheme xtensa-<vendor>_<soc name>-elf (except
the QEMU cores). This renames the overlay directory, and
updating both the config file and github workflows to
match.

Signed-off-by: Daniel Leung <[email protected]>
Copy link
Contributor

@andyross andyross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this the source of the build failure? Something was inconsistent or assuming there were three components? No complaints here about the name beyond verbosity. I guess I must have been thinking along the lines of: "mt" in "mt8195" already implies the vendor. But sure.

@dcpleung
Copy link
Member Author

The naming mismatch between the middle part of the config file name (the part between xtensa- and -elf), and CT_TARGET_VENDOR results in a different output directory being created during the install phase of tools (think make install). So the script couldn't find the output directory and cannot further process the artifacts (e.g. stripping the binaries and remove the duplicate sysroot).

@nashif nashif merged commit 0f841b6 into zephyrproject-rtos:main Aug 30, 2023
20 of 24 checks passed
@dcpleung dcpleung deleted the fix/mtk_mt8195_adsp branch August 30, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants