Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CC13x2x7 and CC26X2X7 support #45

Merged
merged 1 commit into from
Mar 19, 2023

Conversation

jadonk
Copy link

@jadonk jadonk commented Mar 7, 2023

I'm not looking for this to be merged, but BeagleConnect Freedom support depends on it, so it is at least needed to be in the repo such that I can update the west.yml for testing with the CI.

It would really help if @vaishnavachath would get this merged along with the rest of his CC1352P7 support.

Copy link
Member

@cfriedt cfriedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The accompanying PR needs to be green before this is merged.

Just putting a -1 here for safety, temporarily.

@cfriedt
Copy link
Member

cfriedt commented Mar 9, 2023

@stephanosio - can you please make sure that @vaishnavachath has reviewer privileges here and elsewhere?

@stephanosio
Copy link
Member

stephanosio commented Mar 9, 2023

@stephanosio - can you please make sure that @vaishnavachath has reviewer privileges here and elsewhere?

Done. You will be able to add @vaishnavachath as a reviewer once he accepts the invitation.

Also, hal_ti entry in the MAINTAINERS.yml should be updated now that there is a TI platform maintainer.

@cfriedt
Copy link
Member

cfriedt commented Mar 19, 2023

@vaishnavachath, @jadonk - there is something wrong with the 'pthread_self` declaration. I'm not sure if it's new in this PR or what.

https://github.com/zephyrproject-rtos/zephyr/actions/runs/4458113413/jobs/7829701672#step:13:1459

We had a similar issue in hal/ti a while ago.

#44

Looks like this just needs to be rebased.

Add support for CC1352X7 device family in hal_ti, sources are fetched from latest
simplelink SDK simplelink_cc13xx_cc26xx_sdk_6_20_00_29 , should be able to merge
majority of the sources in the X1 and X7 directory. Tested on CC1352P7 launchpad.

Signed-off-by: Vaishnav Achath <[email protected]>
Signed-off-by: Vaishnav Achath <[email protected]>
@vaishnavachath vaishnavachath changed the title Cc13x2x7 support CC13x2x7 and CC26X2X7 support Mar 19, 2023
@vaishnavachath
Copy link
Collaborator

vaishnavachath commented Mar 19, 2023

@cfriedt @jadonk I have rebased the changes on top of the latest commit and the build errors are fixed, https://github.com/zephyrproject-rtos/zephyr/pull/55488/checks
Also there were two commits that was fixing changes in the first commit, since it did not add value to the commit history, I have squashed the commits.
Thank you for the review @cfriedt

@cfriedt cfriedt merged commit 4e0e053 into zephyrproject-rtos:master Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants