Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32WBA Cube 1.4.1 release alignment #237

Merged

Conversation

asm5878
Copy link

@asm5878 asm5878 commented Oct 16, 2024

STM32WBA Cube 1.4.1 release to be integrated

Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, otherwise LGTM

stm32cube/stm32wbaxx/README Outdated Show resolved Hide resolved
lib/stm32wba/hci/ll_intf_cmn.h Outdated Show resolved Hide resolved
stm32cube/stm32wbaxx/README Outdated Show resolved Hide resolved
Update Cube version for STM32WBAxx series
on https://github.com/STMicroelectronics
from version v1.3.1
to version v1.4.1

Signed-off-by: Alessandro Manganaro <[email protected]>
Update Cube version for STM32WBAxx series
on https://github.com/STMicroelectronics
from version v1.3.1
to version v1.4.1

Signed-off-by: Alessandro Manganaro <[email protected]>
Re - generate common_ll headers after Cube updates

Signed-off-by: Alessandro Manganaro <[email protected]>
@asm5878 asm5878 force-pushed the STM32WBA_1_4_1_Cube_Alignment branch from 1484e97 to bf0199f Compare October 18, 2024 09:56
@asm5878 asm5878 requested a review from erwango October 18, 2024 09:57
@asm5878
Copy link
Author

asm5878 commented Oct 18, 2024

PR updated according your inputs, could you please review ?

Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, otherwise LGTM

lib/stm32wba/hci/README Outdated Show resolved Hide resolved
Adding interfaces of MAC only and BLE/Coexistence API
Missing file after cube stm32wba version 1.4.1 update

Signed-off-by: Alessandro Manganaro <[email protected]>
@asm5878 asm5878 force-pushed the STM32WBA_1_4_1_Cube_Alignment branch from bf0199f to dc6c138 Compare October 18, 2024 15:16
@asm5878 asm5878 requested a review from erwango October 18, 2024 15:16
lib/stm32wba/hci/linklayer_plat.c Outdated Show resolved Hide resolved
@asm5878 asm5878 force-pushed the STM32WBA_1_4_1_Cube_Alignment branch from 16ef0ae to 8d98dfe Compare October 24, 2024 13:55
@asm5878 asm5878 requested a review from erwango October 24, 2024 13:56
Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes required otherwise LGTM

lib/stm32wba/hci/README Outdated Show resolved Hide resolved
lib/stm32wba/hci/README Show resolved Hide resolved
@asm5878 asm5878 force-pushed the STM32WBA_1_4_1_Cube_Alignment branch from 8d98dfe to e5da5e4 Compare October 24, 2024 14:51
@asm5878 asm5878 requested a review from erwango October 24, 2024 14:51
@asm5878 asm5878 force-pushed the STM32WBA_1_4_1_Cube_Alignment branch from e5da5e4 to 6b528ff Compare October 24, 2024 22:29
@asm5878
Copy link
Author

asm5878 commented Oct 24, 2024

Just additional clean up

lib/stm32wba/hci/README Outdated Show resolved Hide resolved
@asm5878 asm5878 force-pushed the STM32WBA_1_4_1_Cube_Alignment branch from 6b528ff to 83b7835 Compare October 25, 2024 09:53
@asm5878 asm5878 requested a review from erwango October 25, 2024 09:55
Moving HAL based funcs from zephyr to hal stm32wba hci part.
In this way we separate zephyr based adaptation code from pure
HAL code.

Signed-off-by: Alessandro Manganaro <[email protected]>
@asm5878 asm5878 force-pushed the STM32WBA_1_4_1_Cube_Alignment branch from 83b7835 to 52dc489 Compare October 25, 2024 14:18
@erwango erwango merged commit 019d825 into zephyrproject-rtos:main Oct 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants