Fixes for nrfx_config cleanup #259
Open
+131
−125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masz-nordic
force-pushed
the
nrfx_config
branch
3 times, most recently
from
830efbe
to
602c405
Compare
|
CC @e-rk |
PPI hal cannot be used in config files. Signed-off-by: Marcin Szymczyk <[email protected]>
Non-secure targets for nRF53 and nRF91 need to define peripherals with _NS. Also, there is a special case for GPIOTE. Signed-off-by: Marcin Szymczyk <[email protected]>
masz-nordic
force-pushed
the
nrfx_config
branch
from
602c405
to
d85bb84
Compare
ankuns
reviewed
Nov 26, 2024
| @@ -113,7 +112,7 @@ extern "C" { | |||
| * | |||
| */ | |||
| #ifndef NRF_802154_PPI_RADIO_RAMP_UP_TRIGG | |||
| #define NRF_802154_PPI_RADIO_RAMP_UP_TRIGG NRF_PPI_CHANNEL6 | |||
| #define NRF_802154_PPI_RADIO_RAMP_UP_TRIGG 6 | |||
There was a problem hiding this comment.
Suggested change
| #define NRF_802154_PPI_RADIO_RAMP_UP_TRIGG 6 | |
| #define NRF_802154_PPI_RADIO_RAMP_UP_TRIGG 6U |
Please add U suffix to all NRF_802154_PPI_xxxx definitions you updated.
It is very likely that this file will be overwritten by a deploy from internal sdk-nrf-802154 repo. I'm introducing the changes there with U suffix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.