chore: add a wrapper for PHPUnit binary #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikophil
force-pushed
the
chore/phpunit-wrapper
branch
from
8127e28 to
f8e845f
Compare
nikophil
force-pushed
the
chore/phpunit-wrapper
branch
13 times, most recently
from
956b09c to
b04a0d6
Compare
nikophil
force-pushed
the
chore/phpunit-wrapper
branch
from
b04a0d6 to
6127d86
Compare
nikophil
force-pushed
the
chore/phpunit-wrapper
branch
from
6127d86 to
2730f09
Compare
kbond
reviewed
Aug 15, 2024
kbond
approved these changes
Aug 15, 2024
|
Hi @nikophil Do you plan to release / document this for everyone or is it "just" an internal tool ? |
|
Hi @smnandre I'm not sure to understand your question 😅 It is indeed a very internal tool for Foundry development, which does not aim to be shipped (this makes me think that I've forgotten to add it to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think if we introduce a PHPUnit extension (see #648), it will be harder to test all permutations locally, and to mix dama, the new extension, phpunit version...
Here is a proposal of a wrapper for PHPUnit, which will add the right PHPUnit extension, and automatically upgrade to the right version, based on environment variables:
PHPUNIT_VERSIONUSE_DAMA_DOCTRINE_TEST_BUNDLEUSE_FOUNDRY_PHPUNIT_EXTENSION(soon to come)then, in order to run the test, we just have to run
./phpunit, it will forward to PHPUnit all options or argumentsWould you accept this? I'll add some docs in the readme about this as well