feature: allow to create objects in dataProvider thanks to lazy proxy

zenstruck · Jun 21, 2024 · 233d760 · 233d760
1 parent 80d67f6
commit 233d760
Show file tree

Hide file tree

Showing 12 changed files with 265 additions and 144 deletions.
diff --git a/src/Persistence/IsProxy.php b/src/Persistence/IsProxy.php
@@ -112,6 +112,11 @@ public function _repository(): ProxyRepositoryDecorator
         return new ProxyRepositoryDecorator(parent::class);
     }
 
+    public function _initializeLazyObject(): void
+    {
+        $this->initializeLazyObject();
+    }
+
     private function _autoRefresh(): void
     {
         if (!$this->_getAutoRefresh()) {

diff --git a/src/Persistence/PersistentObjectFactory.php b/src/Persistence/PersistentObjectFactory.php
@@ -203,7 +203,7 @@ final public static function truncate(): void
         static::repository()->truncate();
     }
 
-    final public function create(callable|array $attributes = []): object
+    public function create(callable|array $attributes = []): object
     {
         $object = parent::create($attributes);
 

diff --git a/src/Persistence/PersistentProxyObjectFactory.php b/src/Persistence/PersistentProxyObjectFactory.php
@@ -13,6 +13,7 @@
 
 use Doctrine\Persistence\ObjectRepository;
 use Zenstruck\Foundry\Configuration;
+use Zenstruck\Foundry\Exception\FoundryNotBooted;
 use Zenstruck\Foundry\Factory;
 use Zenstruck\Foundry\Object\Instantiator;
 use Zenstruck\Foundry\FactoryCollection; // keep me!
@@ -36,6 +37,18 @@
  */
 abstract class PersistentProxyObjectFactory extends PersistentObjectFactory
 {
+    /**
+     * @return T&Proxy<T>
+     */
+    public function create(callable|array $attributes = []): object
+    {
+        try {
+            return parent::create($attributes);
+        } catch (FoundryNotBooted) {
+            return ProxyGenerator::wrapFactory($this, $attributes);
+        }
+    }
+
     /**
      * @return class-string<T>
      */

diff --git a/src/Persistence/Proxy.php b/src/Persistence/Proxy.php
@@ -49,4 +49,9 @@ public function _real(): object;
      * @return ProxyRepositoryDecorator<T,ObjectRepository<T>>
      */
     public function _repository(): ProxyRepositoryDecorator;
+
+    /**
+     * @internal
+     */
+    public function _initializeLazyObject(): void;
 }
diff --git a/src/Persistence/ProxyGenerator.php b/src/Persistence/ProxyGenerator.php
@@ -15,11 +15,14 @@
 use Symfony\Component\VarExporter\LazyObjectInterface;
 use Symfony\Component\VarExporter\LazyProxyTrait;
 use Symfony\Component\VarExporter\ProxyHelper;
+use Zenstruck\Foundry\Factory;
 
 /**
  * @author Kevin Bond <[email protected]>
  *
  * @internal
+ *
+ * @phpstan-import-type Attributes from Factory
  */
 final class ProxyGenerator
 {
@@ -43,6 +46,19 @@ public static function wrap(object $object): Proxy
         return self::generateClassFor($object)::createLazyProxy(static fn() => $object); // @phpstan-ignore-line
     }
 
+    /**
+     * @template T of object
+     *
+     * @param PersistentProxyObjectFactory<T> $factory
+     * @phpstan-param Attributes $attributes
+     *
+     * @return T&Proxy<T>
+     */
+    public static function wrapFactory(PersistentProxyObjectFactory $factory, callable|array $attributes): Proxy
+    {
+        return self::generateClassFor($factory)::createLazyProxy(static fn() => $factory->create($attributes)); // @phpstan-ignore-line
+    }
+
     /**
      * @template T
      *
@@ -76,8 +92,8 @@ public static function unwrap(mixed $what): mixed
      */
     private static function generateClassFor(object $object): string
     {
-        /** @var class-string $class */
-        $class = $object instanceof DoctrineProxy ? \get_parent_class($object) : $object::class;
+        $class = self::extractClassName($object);
+
         $proxyClass = self::proxyClassNameFor($class);
 
         /** @var class-string<LazyObjectInterface&Proxy<T>&T> $proxyClass */
@@ -151,4 +167,16 @@ public static function proxyClassNameFor(string $class): string
     {
         return \str_replace('\\', '', $class).'Proxy';
     }
+
+    /**
+     * @return class-string
+     */
+    private static function extractClassName(object $object): string
+    {
+        if ($object instanceof PersistentProxyObjectFactory) {
+            return $object::class();
+        }
+
+        return $object instanceof DoctrineProxy ? \get_parent_class($object) : $object::class; // @phpstan-ignore return.type
+    }
 }
diff --git a/src/Test/Factories.php b/src/Test/Factories.php
@@ -14,7 +14,10 @@
 use PHPUnit\Framework\Attributes\After;
 use PHPUnit\Framework\Attributes\Before;
 use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
+use Symfony\Component\VarExporter\LazyObjectInterface;
+use Webmozart\Assert\Assert;
 use Zenstruck\Foundry\Configuration;
+use Zenstruck\Foundry\Persistence\Proxy;
 
 /**
  * @author Kevin Bond <[email protected]>
@@ -26,7 +29,16 @@ trait Factories
      * @before
      */
     #[Before]
-    public static function _bootFoundry(): void
+    public function _beforeHook(): void
+    {
+        $this->_bootFoundry();
+        $this->_loadDataProvidedProxies();
+    }
+
+    /**
+     * @internal
+     */
+    private function _bootFoundry(): void
     {
         if (!\is_subclass_of(static::class, KernelTestCase::class)) { // @phpstan-ignore-line
             // unit test
@@ -46,6 +58,32 @@ public static function _bootFoundry(): void
         });
     }
 
+    /**
+     * @internal
+     */
+    private function _loadDataProvidedProxies(): void
+    {
+        if (!\is_subclass_of(static::class, KernelTestCase::class)) { // @phpstan-ignore-line
+            return;
+        }
+
+        $providedData = method_exists($this, 'getProvidedData') ? $this->getProvidedData() : $this->providedData(); // @phpstan-ignore method.notFound
+
+        foreach ($providedData as $providedDatum) {
+            if ($providedDatum instanceof Proxy) {
+                $providedDatum->_initializeLazyObject();
+            }
+
+            if (is_array($providedDatum) && count($providedDatum)) {
+                foreach ($providedDatum as $itemFromCollection) {
+                    if ($itemFromCollection instanceof Proxy) {
+                        $itemFromCollection->_initializeLazyObject();
+                    }
+                }
+            }
+        }
+    }
+
     /**
      * @internal
      * @after

diff --git a/tests/Integration/Mongo/GenericDocumentFactoryTest.php b/tests/Integration/Mongo/GenericDocumentFactoryTest.php
@@ -23,7 +23,7 @@ final class GenericDocumentFactoryTest extends GenericFactoryTestCase
 {
     use RequiresMongo;
 
-    protected function factory(): GenericModelFactory
+    protected static function factory(): GenericDocumentFactory
     {
         return GenericDocumentFactory::new();
     }

diff --git a/tests/Integration/Mongo/GenericDocumentProxyFactoryTest.php b/tests/Integration/Mongo/GenericDocumentProxyFactoryTest.php
@@ -26,7 +26,7 @@ final class GenericDocumentProxyFactoryTest extends GenericProxyFactoryTestCase
 {
     use RequiresMongo;
 
-    protected function factory(): PersistentProxyObjectFactory
+    protected static function factory(): GenericProxyDocumentFactory
     {
         return GenericProxyDocumentFactory::new();
     }

diff --git a/tests/Integration/ORM/GenericEntityFactoryTest.php b/tests/Integration/ORM/GenericEntityFactoryTest.php
@@ -23,7 +23,7 @@ final class GenericEntityFactoryTest extends GenericFactoryTestCase
 {
     use RequiresORM;
 
-    protected function factory(): GenericModelFactory
+    protected static function factory(): GenericEntityFactory
     {
         return GenericEntityFactory::new();
     }

diff --git a/tests/Integration/ORM/GenericEntityProxyFactoryTest.php b/tests/Integration/ORM/GenericEntityProxyFactoryTest.php
@@ -26,7 +26,7 @@ final class GenericEntityProxyFactoryTest extends GenericProxyFactoryTestCase
 {
     use RequiresORM;
 
-    protected function factory(): PersistentProxyObjectFactory
+    protected static function factory(): GenericProxyEntityFactory
     {
         return GenericProxyEntityFactory::new();
     }