Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mermaidの記述例をマークダウンガイドに追加 #18

Merged
merged 4 commits into from
Jun 8, 2021

Conversation

cm-wada-yusuke
Copy link
Member

@cm-wada-yusuke cm-wada-yusuke commented Jun 7, 2021

mermaid.js 対応にあたり、articles/markdown-guide.md に記載例と制限事項を追加しました。

関連: zenn-dev/zenn-editor#150

手元で package.json を "zenn-cli": "canary" として確認

image

image

レビュー観点

  • 文書差し込み場所の妥当性
  • 誤字脱字

ご確認いただければと思います。

@cm-wada-yusuke cm-wada-yusuke added the documentation Improvements or additions to documentation label Jun 8, 2021
@cm-wada-yusuke cm-wada-yusuke marked this pull request as ready for review June 8, 2021 01:51
Copy link
Member

@cm-igarashi-ryosuke cm-igarashi-ryosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cm-wada-yusuke 素晴らしい!
LGTM

Copy link
Contributor

@catnose99 catnose99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@catnose99 catnose99 merged commit 45d4fe4 into master Jun 8, 2021
@catnose99 catnose99 deleted the chore/update-docs-for-mermaid branch June 8, 2021 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants