This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 111
tests: Mail\Message produced output not usable by Storage\Message #159
Open
glensc
wants to merge
1
commit into
zendframework:master
Choose a base branch
from
eventum:dogfood-2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,6 +17,7 @@ | |
use Zend\Mail\Storage\Message; | ||
use Zend\Mime; | ||
use Zend\Mime\Exception as MimeException; | ||
use Zend\Mail; | ||
|
||
/** | ||
* @group Zend_Mail | ||
|
@@ -415,6 +416,35 @@ public function testMultivalueToHeader() | |
$this->assertEquals('nicpoń', $addressList->get('[email protected]')->getName()); | ||
} | ||
|
||
/** | ||
* Test case for creating mail with Mail\Message containing \n\n, | ||
* serializing it to text and loading with Storage\Message. | ||
* | ||
* Testcase showing that if mail is created with text body | ||
* that is \n separated, loading such mail with Storage\Message | ||
* causes parse error because it goes into mail body to find headers. | ||
*/ | ||
public function testDogFood() { | ||
$text = "Hello, bödi tekst\n\nBye"; | ||
|
||
$part = new Mime\Part($text); | ||
$part->type = 'text/plain'; | ||
$part->charset = 'UTF-8'; | ||
|
||
$mime = new Mime\Message(); | ||
$mime->addPart($part); | ||
|
||
$message = new Mail\Message(); | ||
$message->setEncoding('UTF-8'); | ||
$message->setBody($text); | ||
|
||
$raw = $message->toString(); | ||
$this->assertContains($text, $raw, "original text is preserved"); | ||
|
||
$message = new Storage\Message(['raw' => $raw]); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this is a
Can you please try and create and post a reproduce case against the zend-mime component? Thanks in advance! |
||
$this->assertNotNull($message); | ||
} | ||
|
||
public function filesProvider() | ||
{ | ||
$filePath = __DIR__ . '/../_files/mail.txt'; | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None of the preceding 7 lines are ever used within the test. Is your setup missing something (attaching a MIME part to the message)? Or can the lines be removed safely?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think they can be removed as the reproducer worked. otherwise i wouldn't had pushed it this way.