-
Notifications
You must be signed in to change notification settings - Fork 35
PSR-7 file upload parameter naming consistency. #82
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is correct that there are an inconsistency between the naming of the PSR-7 interfaces for file uploads and the RenameUpload
filter., but your changes introduces an inconsistency between the option and method name in the filter.
This should be solved without a BC break.
- Only test this one new property. - Make documentation example syntax complete.
Thanks @froschdesign for review and catching same inconsistencies that tripped me up yesterday! |
PSR-17, which is used via the package psr/http-factory, requires PHP 7. Mark those tests as requiring PHP 7 using |
@alextech As it is now it introduces BC Break. We can avoid it by deprecating previous keys and adding new. Also we need to keep old setter/getter (marked as deprecated) and proxy to new one. |
This repository has been closed and moved to laminas/laminas-filter; a new issue has been opened at laminas/laminas-filter#3. |
This repository has been moved to laminas/laminas-filter. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:
|
Upgrading my setup to released version of PSR-7 UploadedFile compatibility for RenameUpload filter #70 caused some confusion. Updating parameter to help resolve it, and suggest a documentation edit to explain where the instances could come from, as I couldn't figure it out without looking at the diff changes of previous PR refactorings.
Add missing unit tests for new options.