-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FS Context #137
Merged
FS Context #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed `BoundContext.call`
Fixed `mkdir` return value Fixed `Dir` tests not using `opendir`
Do you have any feedback on this feature before I merge it? For reference, you can use it like so: import { bindContext, fs } from '@zenfs/core';
import assert from 'assert';
const one = bindContext('/root_1');
one.writeFileSync('/example.txt', 'Not in the real root.');
fs.readFileSync('/root_1/example.txt', 'utf8'); // file contents
assert.deepEqual(one.readdirSync('/../../../..'), fs.readdirSync('/root_1'));
const two = bindContext('/root_2', { uid: 100, gid: 100 }); Feel free to review the code. |
I've merged this PR after some feedback from Marcos. If David has any feedback, I'll handle it on the main branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tracks implementation of contexts, which will be used to isolate FS trees (much like
chroot
)It will resolve #124.