Removed File._setType (+Sync) (folded into chmod)

src/backends/port/fs.ts

@@ -6,7 +6,7 @@ import { Errno, ErrnoError } from '../../error.js';
 import { File } from '../../file.js';
 import { FileSystem, type FileSystemMetadata } from '../../filesystem.js';
 import { Async } from '../../mixins/async.js';
-import { Stats, type FileType } from '../../stats.js';
+import { Stats } from '../../stats.js';
 import type { Backend, FilesystemOf } from '../backend.js';
 import { InMemory } from '../memory.js';
 import * as RPC from './rpc.js';
@@ -104,10 +104,6 @@ export class PortFile extends File {
 		this._throwNoSync('utimes');
 	}
 
-	public _setType(type: FileType): Promise<void> {
-		return this.rpc('_setType', type);
-	}
-
 	public _setTypeSync(): void {
 		this._throwNoSync('_setType');
 	}

src/emulation/promises.ts

@@ -822,7 +822,7 @@ export async function symlink(target: fs.PathLike, path: fs.PathLike, type: fs.s
 
 	await using handle = await _open(path, 'w+', 0o644, false);
 	await handle.writeFile(target.toString());
-	await handle.file._setType(constants.S_IFLNK);
+	await handle.file.chmod(constants.S_IFLNK);
 }
 symlink satisfies typeof promises.symlink;
 

src/emulation/sync.ts

@@ -550,7 +550,7 @@ export function symlinkSync(target: fs.PathLike, path: fs.PathLike, type: fs.sym
 
 	writeFileSync(path, target.toString());
 	const file = _openSync(path, 'r+', 0o644, false);
-	file._setTypeSync(constants.S_IFLNK);
+	file.chmodSync(constants.S_IFLNK);
 }
 symlinkSync satisfies typeof fs.symlinkSync;
 

src/file.ts

@@ -4,7 +4,7 @@ import { O_APPEND, O_CREAT, O_EXCL, O_RDONLY, O_RDWR, O_SYNC, O_TRUNC, O_WRONLY,
 import { Errno, ErrnoError } from './error.js';
 import type { FileSystem } from './filesystem.js';
 import './polyfills.js';
-import { Stats, type FileType } from './stats.js';
+import { _chown, Stats } from './stats.js';
 
 /**
 	Typescript does not include a type declaration for resizable array buffers. 
@@ -251,18 +251,6 @@ export abstract class File<FS extends FileSystem = FileSystem> {
 	 * Change the file timestamps of the file.
 	 */
 	public abstract utimesSync(atime: Date, mtime: Date): void;
-
-	/**
-	 * Set the file type
-	 * @internal
-	 */
-	public abstract _setType(type: FileType): Promise<void>;
-
-	/**
-	 * Set the file type
-	 * @internal
-	 */
-	public abstract _setTypeSync(type: FileType): void;
 }
 
 /**
@@ -573,25 +561,25 @@ export class PreloadFile<FS extends FileSystem> extends File<FS> {
 			throw ErrnoError.With('EBADF', this.path, 'File.chmod');
 		}
 		this.dirty = true;
-		this.stats.chmod(mode);
-		if (config.syncImmediately) await this.sync();
+		this.stats.mode = (this.stats.mode & (mode > S_IFMT ? ~S_IFMT : S_IFMT)) | mode;
+		if (config.syncImmediately || mode > S_IFMT) await this.sync();
 	}
 
 	public chmodSync(mode: number): void {
 		if (this.closed) {
 			throw ErrnoError.With('EBADF', this.path, 'File.chmod');
 		}
 		this.dirty = true;
-		this.stats.chmod(mode);
-		if (config.syncImmediately) this.syncSync();
+		this.stats.mode = (this.stats.mode & (mode > S_IFMT ? ~S_IFMT : S_IFMT)) | mode;
+		if (config.syncImmediately || mode > S_IFMT) this.syncSync();
 	}
 
 	public async chown(uid: number, gid: number): Promise<void> {
 		if (this.closed) {
 			throw ErrnoError.With('EBADF', this.path, 'File.chown');
 		}
 		this.dirty = true;
-		this.stats.chown(uid, gid);
+		_chown(this.stats, uid, gid);
 		if (config.syncImmediately) await this.sync();
 	}
 
@@ -600,7 +588,7 @@ export class PreloadFile<FS extends FileSystem> extends File<FS> {
 			throw ErrnoError.With('EBADF', this.path, 'File.chown');
 		}
 		this.dirty = true;
-		this.stats.chown(uid, gid);
+		_chown(this.stats, uid, gid);
 		if (config.syncImmediately) this.syncSync();
 	}
 
@@ -623,24 +611,6 @@ export class PreloadFile<FS extends FileSystem> extends File<FS> {
 		this.stats.mtime = mtime;
 		if (config.syncImmediately) this.syncSync();
 	}
-
-	public async _setType(type: FileType): Promise<void> {
-		if (this.closed) {
-			throw ErrnoError.With('EBADF', this.path, 'File._setType');
-		}
-		this.dirty = true;
-		this.stats.mode = (this.stats.mode & ~S_IFMT) | type;
-		await this.sync();
-	}
-
-	public _setTypeSync(type: FileType): void {
-		if (this.closed) {
-			throw ErrnoError.With('EBADF', this.path, 'File._setType');
-		}
-		this.dirty = true;
-		this.stats.mode = (this.stats.mode & ~S_IFMT) | type;
-		this.syncSync();
-	}
 }
 
 /**

src/stats.ts

@@ -67,6 +67,10 @@ export interface StatsLike<T extends number | bigint = number | bigint> {
 	 * Inode number
 	 */
 	ino: T;
+	/**
+	 * Number of hard links
+	 */
+	nlink: T;
 }
 
 /**
@@ -277,6 +281,7 @@ export abstract class StatsCommon<T extends number | bigint> implements Node.Sta
 	 * Change the mode of the file.
 	 * We use this helper function to prevent messing up the type of the file.
 	 * @internal
+	 * @deprecated This will be removed in the next minor release since it is internal
 	 */
 	public chmod(mode: number): void {
 		this.mode = this._convert((this.mode & S_IFMT) | mode);
@@ -286,8 +291,9 @@ export abstract class StatsCommon<T extends number | bigint> implements Node.Sta
 	 * Change the owner user/group of the file.
 	 * This function makes sure it is a valid UID/GID (that is, a 32 unsigned int)
 	 * @internal
+	 * @deprecated This will be removed in the next minor release since it is internal
 	 */
-	public chown(uid: number | bigint, gid: number | bigint): void {
+	public chown(uid: number, gid: number): void {
 		uid = Number(uid);
 		gid = Number(gid);
 		if (!isNaN(uid) && 0 <= uid && uid < 2 ** 32) {
@@ -315,6 +321,18 @@ export abstract class StatsCommon<T extends number | bigint> implements Node.Sta
 	}
 }
 
+/**
+ * @hidden @internal
+ */
+export function _chown(stats: Partial<StatsLike<number>>, uid: number, gid: number) {
+	if (!isNaN(uid) && 0 <= uid && uid < 2 ** 32) {
+		stats.uid = uid;
+	}
+	if (!isNaN(gid) && 0 <= gid && gid < 2 ** 32) {
+		stats.gid = gid;
+	}
+}
+
 /**
  * Implementation of Node's `Stats`.
  *