Feature: Add shortcut to enable Rearrange View #3035
+18
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read the comments about adding a new shortcut, hope this is how it should be done.
Added some checks for opened split view menu and that split view is enabled.
I don't know how to properly add the name for the shortcut in the menu and translations for it, since they seem to be in a separate repo.
Additionally while testing I needed to create a new profile for new shortcut to show up, is this intended behavior? Or do I need to remove some cached files for changes to apply?
There are also a typos:
afterRearangeAction
->afterRearrangeAction
this._thumnailCanvas
->this._thumbnailCanvas
Not sure if it's suitable to add here too.
Lastly, I had to disable Prettier for the project because applying the default prettier config from the repo messed up some files I opened, at least
ZenViewSplitter.mjs
has some inconsistencies(e.g._swapField
function has some strange whitespaces)