Update tabbar to fade out tabs on both edges #2701
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ble elements of the tab bar
dosubot
bot
added
size:M
|
Zen doesnt run chromium though |
|
I'm aware, but I'm assuming they both share some common logic as defined in the CSS specification. I was unsuccessful in finding any reports for that problem on Firefox. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the scroll edge detection of the tabbar by reverting it to use the elements list directly instead of filtering the tab list, which yields incorrect bounds due to Zen's changes to the tabbar. Additionally, the mask effect is now also applied to the top edge of the scroll zone when not fully scrolled to the top, similar to what was done on the bottom edge.
There seems to be a rendering bug when an element utilizing
backdrop-filteris masked, resulting in the masking effect stopping at that element. This means that whenever the selected tab is repainted onscreen, it and any tabs below it do not have the mask effect applied on that repaint. Any individual non-selected tabs that are then updated by hovering over them will have the mask applied since then they do not share a repaint with the selected tab. According to Chromium bug report 40284528, this may be due to how the specification for those two styles are defined.