Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed all forced unwrap & support for empty data sets #53

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ekscrypto
Copy link

Should fix several bug reports about unwrapping nil values

@ekscrypto
Copy link
Author

In commit 8311a64 I added support for empty data sets and 1-item data sets; several assumptions about minimum data set sizes like data.count - 1 were sprinkled here and there causing CGFloat.nan and to be generated in the linear scales then later creating crashes during rendering. While I attempted to maintain the current behaviour as much as possible, proper testing should be done to ensure the library is working for all supported scenarios.

@ekscrypto ekscrypto changed the title Removed all forced unwrap Removed all forced unwrap & support for empty data sets Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant