Name some scene cutscenes 2 (Graveyard, Meadow and Lake Hylia) #2339
+19
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fig02
reviewed
Dec 11, 2024
Comment on lines
7
to
8
| <Cutscene Name="gLakeHyliaWaterRaisingCs" Offset="0x55E0"/> | ||
|
|
There was a problem hiding this comment.
The corresponding flag for this cs was just named something to the effect of "lake hylia restored" so maybe we make them consistent. i dont care too much either way
There was a problem hiding this comment.
oh yeah, its still an open pr #2330
There was a problem hiding this comment.
ah I missed this PR, I'll rename it gLakeHyliaRestoredCs then, I think naming it gLakeHyliaRestoredLakeHyliaCs is too redundant (or maybe gLakeHyliaRestoringCs would fit better since this is during the restoration and not after?)
fig02
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
more names™
Graveyard
gGraveyardTombOpeningAdultCs: the adult version of the royal family tomb opening cutscenegGraveyardTombOpeningChildCs: same as above but for child link (I can't notice the difference but there's differences)gGraveyardSunsSongPart2Cs: this is the graveyard camera pan when you learn the sun's songSacred Forest Meadow
gMeadowMinuetCs: the minuet cutscene (this one was already named but I added the scene's name for consistency)gMeadowSariasSongCs: the saria's song cutsceneLake Hylia
gLakeHyliaCreditsCs: that's the camera pan from the creditsgLakeHyliaWaterRaisingCs: this one is the cutscene after getting the medallion where the water is raising