-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce header interdependency #2281
base: main
Are you sure you want to change the base?
Conversation
s32 (*unk_2C)(struct MapMarkIconData***[3]); | ||
s32 (*unk_30)(struct MapMarkIconData***[3]); | ||
void (*unk_34)(struct PauseMapMarkData**[3]); | ||
void (*unk_38)(struct PauseMapMarkData**[3]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find these and the void(**)(struct PlayState*)
below much less readable than with the typedef. Is it really worth it?
ultra64.h should not be split like this, it is a common n64 header file. |
I also am not sure about the specific libultra includes that are occurring in these changes. Pretty sure the intent is that libultra provides a public interface and the game isnt supposed to be able to include specific stuff directly like this, but people more familiar with libultra would have to weigh in |
I just feel that including the entirety of libultra when a file only needs the ultratypes is overkill and some files already did it this way so I thought it'd be fine. |
Reduces some instances of headers needlessly depending on other headers, should help with BSS stability.