Misc Updates #2465
Misc Updates #2465
Conversation
robhyrk
commented
Jan 14, 2025
robhyrk
commented
- remove airdrop btn and memecoin markets from front page
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
components/front-page/Topics.tsx
Outdated
| className={` | ||
| {topics.map((topic, index) => { | ||
| return ( | ||
| //TODO: temp solution. waiting for login |
There was a problem hiding this comment.
What do you mean by waiting for login? Do you need login access to the content management system, in which you can deactivate topics on the front end?
components/front-page/Topics.tsx
Outdated
| <Image | ||
| {topics.map((topic, index) => { | ||
| return ( | ||
| topic.slug !== "gaza" && ( |
There was a problem hiding this comment.
I think you meant memecoin-markets here instead of gaza, but anyways... I don't think it's optimal to exclude the memecoin-markets here in this Topics component, because this line indicates that it will select the first entry from the CMS, which is the memecoin-markets entry. I would rather wait for the access of the CMS instead of doing the dirty fix like here. When will you get access to the CMS? If it took too long to gain access to the CMS, I would suggest changing this line to skip to the next item from the CMS if the memecoin-markets topic is going to be selected.
There was a problem hiding this comment.
yes, thank you. haven't touched Zeitgeist code for a while so just getting back to it. I saw your comment from earlier on DIscord and have removed the sections as per your suggestion
|
E2E Tests failing in the CI? |
I'm not sure if these are even setup correctly so I'll need to look into it. Might just disable until we can get a fix on it |
