-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Feedback Table to support User Feedback #229
Conversation
- Added two new tables to allow support for User feedback from a popup in the app. This component will be placed in various components so we can collect feedback from users if something is not working.
- This is used quite a few places, so let's wait with removing it and for now let's keep the same functionality as before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good. two small comment-related observations
class UserFeedbackReport(db.Model): | ||
""" | ||
|
||
A search filter is created when the user |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment is from a different class :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's what I get from starting from another file!
I have updated it.
""" | ||
|
||
A Feedback Component is a component of the Web that the user | ||
can report an issue from. They pick one from a drop-down list |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They pick ... is talking about the component_type
field, right? because now the comment is a bit hard to parse.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, so I wanted to explain that the options the user see depend on the context where they are in the Front end - I tried rephrasing it a bit to see if it makes more sense.
… user will report their feedback. Or upload their feedback. But the entity that's in the db is the Feedback, not the report.
Changes:
The changes from the web are still being discussed - so I will wait with making the PR of the web side, but I think we can implement the back-end so when we are ready in the frontend we can deploy.