Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Feedback Table to support User Feedback #229

Merged
merged 7 commits into from
Oct 4, 2024

Conversation

tfnribeiro
Copy link
Collaborator

@tfnribeiro tfnribeiro commented Sep 26, 2024

Changes:

  • When a user would report an issue we were sending an email to alert us that someone had an issue.
  • For better tracking of issues, we are creating tables to keep track of the components and changes. We can add new components as time goes on and we introduce new features to the the app.
  • We also keep storing the URLs, especially if we need to find some particular component or part of our application that might have more issues than others.
  • I am not expecting long feedback from the users, but I have made the message accept up to 512 chars.

The changes from the web are still being discussed - so I will wait with making the PR of the web side, but I think we can implement the back-end so when we are ready in the frontend we can deploy.

- Added two new tables to allow support for User feedback from a popup in the app. This component will be placed in various components so we can collect feedback from users if something is not working.
- This is used quite a few places, so let's wait with removing it and for now let's keep the same functionality as before.
@tfnribeiro tfnribeiro linked an issue Sep 26, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Sep 26, 2024

Module view diffs:
diffdiffdiff

Copy link
Member

@mircealungu mircealungu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good. two small comment-related observations

class UserFeedbackReport(db.Model):
"""

A search filter is created when the user
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment is from a different class :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what I get from starting from another file!

I have updated it.

"""

A Feedback Component is a component of the Web that the user
can report an issue from. They pick one from a drop-down list
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They pick ... is talking about the component_type field, right? because now the comment is a bit hard to parse.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, so I wanted to explain that the options the user see depend on the context where they are in the Front end - I tried rephrasing it a bit to see if it makes more sense.

… user will report their feedback. Or upload their feedback. But the entity that's in the db is the Feedback, not the report.
@mircealungu mircealungu merged commit 4359af7 into master Oct 4, 2024
3 checks passed
@mircealungu mircealungu deleted the 228-add-feedback-to-the-db-model branch October 4, 2024 21:31
@mircealungu mircealungu restored the 228-add-feedback-to-the-db-model branch October 4, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Feedback to the DB Model
2 participants