Lower the threshold to show read articles. #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tfnribeiro
commented
Sep 17, 2024
tfnribeiro
commented
- I realized the units weren't correct in the check. It should be in decimals (percentage) rather than int. - I can still see that sometimes I finish an article but it's still popping up in my feed, so maybe lowering it to 0.9 might be a good idea. @mircealungu has this ever occurred to you?
- I realized the units weren't correct in the check. It should be in decimals (percentage) rather than int. - I can still see that sometimes I finish an article but it's still popping up in my feed, so maybe lowering it to 0.9 mght be a good idea.
|
Module view diffs: |
|
I didn't observe this happening. But I'll merge in the hope of not observing it in the future :) |
mircealungu
deleted the
215-decrease-the-threshold-to-mark-an-article-as-read
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.