assistant2: Suggest current file as context #22526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
agu-z
commented
Dec 31, 2024
Comment on lines
+96
to
+97
| if self.workspace_active_pane_id != new_active_item_id { | ||
| self.suggested_context = Self::suggested_file(active_item, cx); |
There was a problem hiding this comment.
For some reason, workspace emits the ActiveItemChanged event many times when the active item changes.
agu-z
commented
Dec 31, 2024
Comment on lines
+49
to
+56
| pub fn contains_project_entry(&self, entry_id: ProjectEntryId) -> bool { | ||
| self.context.iter().any(|probe| match probe.kind { | ||
| ContextKind::File(probe_entry_id) => probe_entry_id == entry_id, | ||
| ContextKind::Directory => false, | ||
| ContextKind::FetchedUrl => false, | ||
| ContextKind::Thread => false, | ||
| }) | ||
| } |
There was a problem hiding this comment.
I think the linear search should be ok for the current usage, but we may want to consider an alternative approach if we use this to filter file_context_picker entries later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggest adding the current file as context in the new assistant panel.
CleanShot.2024-12-31.at.19.11.24.mp4
Note: This doesn't include suggesting the current thread in the inline assistant.
Release Notes: