-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add image dimension and file size information #21675
Open
kaf-lamed-beyt
wants to merge
16
commits into
zed-industries:main
Choose a base branch
from
kaf-lamed-beyt:worktree-abspath
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+287
−10
Open
Changes from 2 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
392e6f8
chore: show image info
kaf-lamed-beyt 5874639
Merge branch 'main' of github.com:kaf-lamed-beyt/zed
kaf-lamed-beyt da13757
implement image_info StatusItemView
kaf-lamed-beyt b27afc4
minor
kaf-lamed-beyt bd466ef
fix: use async Fs instead in favour of std::fs
kaf-lamed-beyt c221619
Merge branch 'main' into worktree-abspath
kaf-lamed-beyt 5511e2f
feat: allow users to chose their preferred units of measurements for …
kaf-lamed-beyt dc1eb2f
Merge branch 'main' into worktree-abspath
kaf-lamed-beyt 1a6229f
refactor
kaf-lamed-beyt 9d65395
Merge branch 'main' into worktree-abspath
kaf-lamed-beyt a0dcce0
Merge branch 'worktree-abspath' of github.com:kaf-lamed-beyt/zed into…
kaf-lamed-beyt ad8627e
get fs from project instead of creating a new pointer
kaf-lamed-beyt 00f076b
update cargo lock
kaf-lamed-beyt aceb577
Merge branch 'main' into worktree-abspath
kaf-lamed-beyt 120732f
fix block on
0xtimsb 7805335
Merge pull request #1 from 0xtimsb/fix-block-on
kaf-lamed-beyt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,3 +23,4 @@ theme.workspace = true | |
ui.workspace = true | ||
util.workspace = true | ||
workspace.workspace = true | ||
image = "0.25.5" | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's elevate this dependency, and the one in GPUI, to a workspace dependency