-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: compile command logic when using id-as
ice
#619
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladdoster
changed the title
Fix/compile command
fix: compile command logic when using Jan 13, 2024
id-as
ice
vladdoster
force-pushed
the
fix/compile_command
branch
from
January 19, 2024 05:20
a7cd2a2
to
fed4f3e
Compare
vladdoster
force-pushed
the
fix/compile_command
branch
from
February 11, 2024 04:47
fed4f3e
to
3b9c0cc
Compare
Signed-off-by: Vladislav Doster <[email protected]>
vladdoster
force-pushed
the
fix/compile_command
branch
from
February 11, 2024 10:34
602d9e9
to
4acabc8
Compare
Signed-off-by: Vladislav Doster <[email protected]>
vladdoster
force-pushed
the
fix/compile_command
branch
from
February 11, 2024 13:06
98c3162
to
e15d34e
Compare
Signed-off-by: Vladislav Doster <[email protected]>
Signed-off-by: Vladislav Doster <[email protected]>
Signed-off-by: Vladislav Doster <[email protected]>
Signed-off-by: Vladislav Doster <[email protected]>
Signed-off-by: Vladislav Doster <[email protected]>
Signed-off-by: Vladislav Doster <[email protected]>
vladdoster
force-pushed
the
fix/compile_command
branch
from
March 2, 2024 17:21
6f43c85
to
2491ebe
Compare
Signed-off-by: Vladislav Doster <[email protected]>
vladdoster
commented
Mar 3, 2024
vladdoster
commented
Mar 3, 2024
vladdoster
commented
Mar 3, 2024
vladdoster
commented
Mar 3, 2024
vladdoster
force-pushed
the
fix/compile_command
branch
from
March 3, 2024 10:57
f06c48d
to
62efe22
Compare
Signed-off-by: Vladislav Doster <[email protected]>
Signed-off-by: Vladislav Doster <[email protected]>
Signed-off-by: Vladislav Doster <[email protected]>
Signed-off-by: Vladislav Doster <[email protected]>
vladdoster
force-pushed
the
fix/compile_command
branch
from
March 3, 2024 11:00
62efe22
to
688fc62
Compare
Signed-off-by: Vladislav Doster <[email protected]>
Signed-off-by: Vladislav Doster <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue where plugins using
id-as
ice would not not be correctly handled when runningzinit compile --all
. Compiling a single plugin worked, but the logic for compiling all plugins was broken.Additionally, this cleans up the log message logic to reflect what is actually done.
Related Issue(s)
Motivation and Context
Usage examples
How Has This Been Tested?
Types of changes
Checklist: