Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compile command logic when using id-as ice #619

Merged
merged 16 commits into from
Mar 4, 2024
Merged

Conversation

vladdoster
Copy link
Member

@vladdoster vladdoster commented Jan 13, 2024

Description

Fixes issue where plugins using id-as ice would not not be correctly handled when running zinit compile --all. Compiling a single plugin worked, but the logic for compiling all plugins was broken.

Additionally, this cleans up the log message logic to reflect what is actually done.

Screenshot 2024-01-13 at 05 55 15 Screenshot 2024-01-13 at 06 08 57

Related Issue(s)

Motivation and Context

Usage examples

How Has This Been Tested?

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • Documentation change
  • New feature (non-breaking change which adds functionality)

Checklist:

  • All new and existing tests passed.
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.

@vladdoster vladdoster marked this pull request as ready for review January 13, 2024 16:20
@vladdoster vladdoster changed the title Fix/compile command fix: compile command logic when using id-as ice Jan 13, 2024
@vladdoster vladdoster self-assigned this Jan 14, 2024
@github-actions github-actions bot added the tests label Jan 19, 2024
Signed-off-by: Vladislav Doster <[email protected]>
@github-actions github-actions bot added the docs label Feb 11, 2024
@vladdoster vladdoster marked this pull request as draft February 11, 2024 12:52
Signed-off-by: Vladislav Doster <[email protected]>
Signed-off-by: Vladislav Doster <[email protected]>
Signed-off-by: Vladislav Doster <[email protected]>
Signed-off-by: Vladislav Doster <[email protected]>
Signed-off-by: Vladislav Doster <[email protected]>
Signed-off-by: Vladislav Doster <[email protected]>
@vladdoster vladdoster marked this pull request as ready for review February 20, 2024 01:32
@vladdoster vladdoster force-pushed the fix/compile_command branch from 6f43c85 to 2491ebe Compare March 2, 2024 17:21
@github-actions github-actions bot added the ci/cd label Mar 3, 2024
tests/_support/bootstrap Outdated Show resolved Hide resolved
zinit.zsh Show resolved Hide resolved
zinit.zsh Outdated Show resolved Hide resolved
@vladdoster vladdoster force-pushed the fix/compile_command branch from f06c48d to 62efe22 Compare March 3, 2024 10:57
Signed-off-by: Vladislav Doster <[email protected]>
Signed-off-by: Vladislav Doster <[email protected]>
Signed-off-by: Vladislav Doster <[email protected]>
Signed-off-by: Vladislav Doster <[email protected]>
@vladdoster vladdoster force-pushed the fix/compile_command branch from 62efe22 to 688fc62 Compare March 3, 2024 11:00
@vladdoster vladdoster merged commit b7b8347 into main Mar 4, 2024
4 checks passed
@vladdoster vladdoster deleted the fix/compile_command branch March 4, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant