feat: check for completion files #618
Conversation
vladdoster
force-pushed
the
feat/smart-completion
branch
from
483d0c3 to
8e65a67
Compare
vladdoster
force-pushed
the
feat/smart-completion
branch
3 times, most recently
from
0c75196 to
ee9adb7
Compare
|
Automatically detect completion files 
|
|
@jankatins, thoughts? |
| local c cfile bkpfile | ||
| # The plugin == . is a semi-hack/trick to handle 'creinstall .' properly | ||
| nt () { |
There was a problem hiding this comment.
nt is just a random function name. It could be anything.
There was a problem hiding this comment.
Ok, stupid question: why not a speaking function name so one can actually know what it does by just reading the function name? reading the zinit code is hard enough even without random function names :-)
There was a problem hiding this comment.
|
To be honest, I'm fine with the "less magic" variant of renaming to What happens if two files end up getting symlinked under the same name? |
| assert $state equals 0 | ||
| assert "$ZPLUGINS/test---ignored_completions/_valid" is_file | ||
| assert "$ZPLUGINS/test---ignored_completions/__init__.py" is_file | ||
| assert "$ZINIT[COMPLETIONS_DIR]/_valid" is_file | ||
| COMPS=( "$ZINIT[COMPLETIONS_DIR]"/_* ) | ||
| assert __init__.py is_not_value_in $COMPS | ||
| zinit delete --yes test/ignored_completions | ||
| run zinit cuninstall test/ignored_completions | ||
| assert $output contains 'No completions found for `test/ignored_completions' |
There was a problem hiding this comment.
There should be a test with two files of the same name getting linked under different names.
There was a problem hiding this comment.
@jankatins Good idea.
Signed-off-by: Vladislav Doster <[email protected]>
vladdoster
force-pushed
the
feat/smart-completion
branch
from
e266994 to
627ea8e
Compare
Signed-off-by: Vladislav Doster <[email protected]>
|
|
||
|
|
||
| - name: "gh-r" | ||
| run: $HOME/.local/bin/zunit run --verbose tests/gh-r.zunit |
There was a problem hiding this comment.
| run: $HOME/.local/bin/zunit run --verbose tests/gh-r.zunit | |
| run: zunit run --verbose tests/gh-r.zunit |
Description
Related Issue(s)
Motivation and Context
Usage examples
before
after
How Has This Been Tested?
Types of changes
Checklist: