Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transparent: Fix bugs in AccountPubKey::derive_pubkey_at_bip32_path #1667

Merged
merged 5 commits into from
Dec 17, 2024

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Dec 17, 2024

  • A typo in a panic guard condition instead exposed the panic.
  • The match logic wasn't correctly handling the first element of the path.

@str4d str4d force-pushed the transparent-key-deriv-bugfix branch from 68ed086 to 36a374b Compare December 17, 2024 13:16
@str4d
Copy link
Contributor Author

str4d commented Dec 17, 2024

Force-pushed to fix clippy lint.

- A typo in a panic guard condition instead exposed the panic.
- The match logic wasn't correctly handling the first element of the
  path.
@str4d str4d force-pushed the transparent-key-deriv-bugfix branch from 36a374b to 06f3eb7 Compare December 17, 2024 13:21
@str4d
Copy link
Contributor Author

str4d commented Dec 17, 2024

Force-pushed to extend the test.

str4d added a commit that referenced this pull request Dec 17, 2024
Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 06f3eb7

@str4d str4d merged commit 0255874 into main Dec 17, 2024
30 checks passed
@str4d str4d deleted the transparent-key-deriv-bugfix branch December 17, 2024 14:20
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 53.01%. Comparing base (a1e4e7a) to head (06f3eb7).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
zcash_transparent/src/keys.rs 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1667      +/-   ##
==========================================
+ Coverage   52.94%   53.01%   +0.06%     
==========================================
  Files         175      175              
  Lines       21072    21073       +1     
==========================================
+ Hits        11157    11171      +14     
+ Misses       9915     9902      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants