-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
transparent: Fix bugs in AccountPubKey::derive_pubkey_at_bip32_path
#1667
Conversation
str4d
commented
Dec 17, 2024
- A typo in a panic guard condition instead exposed the panic.
- The match logic wasn't correctly handling the first element of the path.
68ed086
to
36a374b
Compare
Force-pushed to fix clippy lint. |
- A typo in a panic guard condition instead exposed the panic. - The match logic wasn't correctly handling the first element of the path.
36a374b
to
06f3eb7
Compare
Force-pushed to extend the test. |
Brings #1667 into the Keystone firmware branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK 06f3eb7
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1667 +/- ##
==========================================
+ Coverage 52.94% 53.01% +0.06%
==========================================
Files 175 175
Lines 21072 21073 +1
==========================================
+ Hits 11157 11171 +14
+ Misses 9915 9902 -13 ☔ View full report in Codecov by Sentry. |