zcash_keys: Enable no_std usage.
#1661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1661 +/- ##
==========================================
+ Coverage 52.94% 53.01% +0.06%
==========================================
Files 175 175
Lines 21072 21073 +1
==========================================
+ Hits 11157 11171 +14
+ Misses 9915 9902 -13 ☔ View full report in Codecov by Sentry. |
nuttycom
force-pushed
the
zcash_keys_no_std
branch
from
100512a to
7e23130
Compare
nuttycom
force-pushed
the
zcash_keys_no_std
branch
from
7e23130 to
accbb23
Compare
str4d
reviewed
Dec 16, 2024
There was a problem hiding this comment.
utACK accbb23. Blocked from merging on a no-std-compatible release of nonempty.
Once we have released the stack of crates, we will rebase this (and zcash/orchard#446) to assemble the branch sequence that the Keystone firmware will depend on; at that point this will become a feature branch.
nuttycom
force-pushed
the
zcash_keys_no_std
branch
from
accbb23 to
fad7f38
Compare
str4d
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cannot be merged until we have
nonemptyandorchardreleases that supportno_std