-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Do not merge] Check that CI test failures show backtraces #1604
Conversation
…unds closes zcash#1411 - Adds min_confirmations to transparent account balances - Adds a new `transparent_balance_spendability` test to verify transparent funds spendability. - cargo clippy + cargo fmt Refactor: Extract Method on lambda `check_balance`
Signed-off-by: Daira-Emma Hopwood <[email protected]>
Signed-off-by: Daira-Emma Hopwood <[email protected]>
* `cargo test --all-targets --all-features`: * 484s (354s build, 130s tests) * `cargo test --release --all-targets --all-features`: * 541s (415s build, 126s tests) * `cargo test --profile=dev --all-targets --all-features`: * 1709s (146s build, 1563s tests) * this might still be faster when running individual tests
Signed-off-by: Daira-Emma Hopwood <[email protected]>
Here are the backtraces for the expected failure. From CI:
Locally with Locally with
Obtaining nearly the same stack trace as with full debug info, and with an overall improvement in build+test time, seems like a good deal to me. |
This is
pacu/feature/transparent-balance
from #1570, at a commit known to have a test failure, with #1603 cherry-picked onto it.