zcash_client_sqlite: Always check for seed relevance in init_wallet_db
#1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
str4d
force-pushed
the
1283-zcs-migration-seed-relevance
branch
from
f9aa896 to
a15ebf7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1286 +/- ##
==========================================
- Coverage 63.54% 63.46% -0.09%
==========================================
Files 121 121
Lines 13820 13890 +70
==========================================
+ Hits 8782 8815 +33
- Misses 5038 5075 +37 ☔ View full report in Codecov by Sentry. |
nuttycom
previously approved these changes
Mar 19, 2024
Comment on lines
+253
to
+254
| seed: &SecretVec<u8>, | ||
| seed_fingerprint: &SeedFingerprint, |
There was a problem hiding this comment.
I find it surprising that this takes both the seed and the seed fingerprint, but I guess that since it's a helper it's fine.
There was a problem hiding this comment.
These are from two different data sources:
seedcomes from the caller.seed_fingerprintcomes from the wallet.
The helper is explicitly checking their consistency.
The blanket `impl Account<A> for (A, Option<UnifiedFullViewingKey>)` is removed because we cannot know the UIVK for `(A, None)`. We instead provide a blanket impl for `(A, UnifiedIncomingViewingKey)`. We also move both of them behind `test-dependencies` because they are only intended for testing purposes.
The previous implementation was mixing the caller-provided seed with the wallet-provided ZIP 32 account index, and throwing an error if the USK derivation failed. We instead need to count that as a mismatch, because the wallet account's actual seed would derive a USK fine (because wallet accounts are required to have a known UIVK).
str4d
force-pushed
the
1283-zcs-migration-seed-relevance
branch
from
a15ebf7 to
4fa0547
Compare
|
Force-pushed to address review comments. |
nuttycom
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1283.