Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add
WalletRead::get_seed_account
#1259Add
WalletRead::get_seed_account
#1259Changes from all commits
33e943d
328e854
79f5bb4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 1601 in zcash_client_backend/src/data_api.rs
Codecov / codecov/patch
zcash_client_backend/src/data_api.rs#L1601
Check warning on line 1606 in zcash_client_backend/src/data_api.rs
Codecov / codecov/patch
zcash_client_backend/src/data_api.rs#L1606
Check warning on line 408 in zcash_client_sqlite/src/lib.rs
Codecov / codecov/patch
zcash_client_sqlite/src/lib.rs#L408
Check warning on line 413 in zcash_client_sqlite/src/lib.rs
Codecov / codecov/patch
zcash_client_sqlite/src/lib.rs#L413
Check warning on line 784 in zcash_client_sqlite/src/wallet.rs
Codecov / codecov/patch
zcash_client_sqlite/src/wallet.rs#L784
Check warning on line 790 in zcash_client_sqlite/src/wallet.rs
Codecov / codecov/patch
zcash_client_sqlite/src/wallet.rs#L790
Check warning on line 800 in zcash_client_sqlite/src/wallet.rs
Codecov / codecov/patch
zcash_client_sqlite/src/wallet.rs#L797-L800
Check warning on line 812 in zcash_client_sqlite/src/wallet.rs
Codecov / codecov/patch
zcash_client_sqlite/src/wallet.rs#L802-L812
Check warning on line 819 in zcash_client_sqlite/src/wallet.rs
Codecov / codecov/patch
zcash_client_sqlite/src/wallet.rs#L819
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this; I was unaware that uniqueness constraints were starting to be embedded in the indices (which prior to now I only thought were present for performance). I rely heavily on changes to
init.rs
to track changes to the database structure and determine what constraints are applied.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand the full subtleties of
UNIQUE INDEX
vsCONSTRAIN UNIQUE
and why you'd choose one over the other. AFAICT:UNIQUE INDEX
can be removed and added without altering the table (and I guessCREATE UNIQUE INDEX
fails if the table contains non-unique data?)UNIQUE INDEX
can include expressionsCONSTRAIN UNIQUE
has greater support inON CONFLICT
logic (whereasUNIQUE INDEX
only supportsINSERT ... ON CONFLICT
I think).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I was looking at this today. I think that the
ON CONFLICT
capabilities are actually the same, from what I was reading, at least for recent releases? Given that the separate indices can be dropped and added independently, I think I have a slight preference for them, but I don't think it makes much difference one way or the other.