Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zcash_client_sqlite: Add database tables for Orchard #1254

Merged
merged 2 commits into from
Mar 11, 2024
Merged

zcash_client_sqlite: Add database tables for Orchard #1254

merged 2 commits into from
Mar 11, 2024

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Mar 11, 2024

Closes #1227.

@str4d str4d added this to the Librustzcash Zashi 1.0 milestone Mar 11, 2024
Base automatically changed from more-orchard-tests to main March 11, 2024 14:31
nuttycom
nuttycom previously approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK; we will need to add CHANGELOG entries for the views

@codecov Codecov
Copy link

codecov bot commented Mar 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 73.65439% with 93 lines in your changes are missing coverage. Please review.

Project coverage is 63.82%. Comparing base (de58b5a) to head (ae9dd25).
Report is 1 commits behind head on main.

Files Patch % Lines
zcash_client_sqlite/src/lib.rs 0.00% 30 Missing ⚠️
...te/src/wallet/init/migrations/orchard_shardtree.rs 69.76% 26 Missing ⚠️
zcash_client_sqlite/src/wallet/scanning.rs 5.55% 17 Missing ⚠️
zcash_client_sqlite/src/testing.rs 0.00% 7 Missing ⚠️
zcash_client_sqlite/src/wallet.rs 0.00% 7 Missing ⚠️
...c/wallet/init/migrations/orchard_received_notes.rs 98.00% 4 Missing ⚠️
zcash_client_backend/src/data_api.rs 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1254      +/-   ##
==========================================
+ Coverage   63.49%   63.82%   +0.32%     
==========================================
  Files         117      119       +2     
  Lines       12654    12999     +345     
==========================================
+ Hits         8035     8296     +261     
- Misses       4619     4703      +84

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

str4d
str4d commented Mar 11, 2024
View reviewed changes
Copy link
Contributor Author

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed fe0b6c7.

zcash_client_backend/src/data_api.rs Show resolved Hide resolved
zcash_client_sqlite/src/wallet/init/migrations.rs Show resolved Hide resolved
zcash_client_sqlite/src/wallet/scanning.rs Outdated Show resolved Hide resolved
zcash_client_sqlite/src/wallet/init.rs Outdated Show resolved Hide resolved
zcash_client_sqlite/src/wallet/init/migrations/orchard_received_notes.rs Outdated Show resolved Hide resolved
zcash_client_sqlite/src/wallet/init/migrations/orchard_shardtree.rs Outdated Show resolved Hide resolved
zcash_client_sqlite/src/wallet/init/migrations/orchard_shardtree.rs Outdated Show resolved Hide resolved
zcash_client_sqlite/src/wallet/init/migrations/orchard_shardtree.rs Show resolved Hide resolved
zcash_client_sqlite/src/wallet/init/migrations/orchard_shardtree.rs Outdated Show resolved Hide resolved
zcash_client_sqlite/src/wallet/init/migrations/orchard_shardtree.rs Show resolved Hide resolved
@str4d
Copy link
Contributor Author

str4d commented Mar 11, 2024

Force-pushed to address review comments.

nuttycom
nuttycom approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK ae9dd25

daira
daira reviewed Mar 11, 2024
View reviewed changes
zcash_client_sqlite/src/wallet/scanning.rs
@@ -415,9 +445,21 @@ pub(crate) fn update_chain_tip<P: consensus::Parameters>(
// `ScanRange` uses an exclusive upper bound.
let chain_end = new_tip + 1;

// Read the maximum height from the shards table.
// Read the maximum height from each of the the shards tables. The minimum of the two
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Read the maximum height from each of the the shards tables. The minimum of the two
// Read the maximum height from each of the shards tables. The minimum of the two

Non-blocking.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in #1182.

daira
daira reviewed Mar 11, 2024
View reviewed changes
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the last force-push with @str4d.

@str4d str4d merged commit 0780272 into main Mar 11, 2024
23 of 26 checks passed
@str4d str4d deleted the orchard-tables branch March 11, 2024 17:27
@str4d str4d mentioned this pull request Mar 11, 2024
Merged
@nuttycom nuttycom mentioned this pull request Mar 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daira daira daira left review comments

@nuttycom nuttycom nuttycom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Librustzcash Zashi 1.0
Development

Successfully merging this pull request may close these issues.

zcash_client_sqlite: Add database tables for Orchard
3 participants
@str4d @nuttycom @daira