zcash_client_sqlite: Add index verification to verify_schema

zcash · Mar 12, 2024 · 79f5bb4 · 79f5bb4
1 parent 328e854
commit 79f5bb4
Show file tree

Hide file tree

Showing 2 changed files with 50 additions and 2 deletions.
diff --git a/zcash_client_sqlite/src/wallet/init.rs b/zcash_client_sqlite/src/wallet/init.rs
@@ -436,6 +436,54 @@ mod tests {
             expected_idx += 1;
         }
 
+        let expected_indices = vec![
+            r#"CREATE UNIQUE INDEX accounts_ufvk ON "accounts" (ufvk)"#,
+            r#"CREATE UNIQUE INDEX accounts_uivk ON "accounts" (uivk)"#,
+            r#"CREATE UNIQUE INDEX hd_account ON "accounts" (hd_seed_fingerprint, hd_account_index)"#,
+            r#"CREATE INDEX "addresses_accounts" ON "addresses" (
+                "account_id" ASC
+            )"#,
+            r#"CREATE INDEX nf_map_locator_idx ON nullifier_map(block_height, tx_index)"#,
+            r#"CREATE INDEX orchard_received_notes_account ON orchard_received_notes (
+                account_id ASC
+            )"#,
+            r#"CREATE INDEX orchard_received_notes_spent ON orchard_received_notes (
+                spent ASC
+            )"#,
+            r#"CREATE INDEX orchard_received_notes_tx ON orchard_received_notes (
+                tx ASC
+            )"#,
+            r#"CREATE INDEX "sapling_received_notes_account" ON "sapling_received_notes" (
+                "account_id" ASC
+            )"#,
+            r#"CREATE INDEX "sapling_received_notes_spent" ON "sapling_received_notes" (
+                "spent" ASC
+            )"#,
+            r#"CREATE INDEX "sapling_received_notes_tx" ON "sapling_received_notes" (
+                "tx" ASC
+            )"#,
+            r#"CREATE INDEX sent_notes_from_account ON "sent_notes" (from_account_id)"#,
+            r#"CREATE INDEX sent_notes_to_account ON "sent_notes" (to_account_id)"#,
+            r#"CREATE INDEX sent_notes_tx ON "sent_notes" (tx)"#,
+            r#"CREATE INDEX utxos_received_by_account ON "utxos" (received_by_account_id)"#,
+            r#"CREATE INDEX utxos_spent_in_tx ON "utxos" (spent_in_tx)"#,
+        ];
+        let mut indices_query = st
+            .wallet()
+            .conn
+            .prepare("SELECT sql FROM sqlite_master WHERE type = 'index' AND sql != '' ORDER BY tbl_name, name")
+            .unwrap();
+        let mut rows = indices_query.query([]).unwrap();
+        let mut expected_idx = 0;
+        while let Some(row) = rows.next().unwrap() {
+            let sql: String = row.get(0).unwrap();
+            assert_eq!(
+                re.replace_all(&sql, " "),
+                re.replace_all(expected_indices[expected_idx], " ")
+            );
+            expected_idx += 1;
+        }
+
         let expected_views = vec![
             // v_orchard_shard_scan_ranges
             format!(

diff --git a/zcash_client_sqlite/src/wallet/init/migrations/full_account_ids.rs b/zcash_client_sqlite/src/wallet/init/migrations/full_account_ids.rs
@@ -70,8 +70,8 @@ impl<P: consensus::Parameters> RusqliteMigration for Migration<P> {
                 )
             );
             CREATE UNIQUE INDEX hd_account ON accounts_new (hd_seed_fingerprint, hd_account_index);
-            CREATE UNIQUE INDEX accounts_uivk ON accounts_new ("uivk");
-            CREATE UNIQUE INDEX accounts_ufvk ON accounts_new ("ufvk");
+            CREATE UNIQUE INDEX accounts_uivk ON accounts_new (uivk);
+            CREATE UNIQUE INDEX accounts_ufvk ON accounts_new (ufvk);
             "#),
         )?;