Transaction helper #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
str4d
force-pushed
the
transaction-helper
branch
from
b028c93 to
7830263
Compare
str4d
commented
Mar 19, 2018
| if (this._jsouts.length) { | ||
| return Math.ceil(this._jsouts.length / 2) | ||
| } else { | ||
| return Math.ceil(this.jss.length / 2) |
| ), arguments) | ||
|
|
||
| // Add the JSOutput and return the JSOutput's index | ||
| return (this._jsouts.push(new JSOutput(addr, value, memo)) - 1) |
There was a problem hiding this comment.
Error if getProofs() has been called.
| var dataToBeSigned = signatureHashFn(NOT_AN_INPUT, scriptCode, SIGHASH_ALL) | ||
|
|
||
| // Add the signature | ||
| this.joinSplitSig = Buffer.from(sodium.crypto_sign_detached(dataToBeSigned, this._joinSplitPrivKey)) |
There was a problem hiding this comment.
Error if getProofs() has not been called.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a helper for library users to implement the Zcash modifications to the Bitcoin transaction format. It also implements the client-side of the payment offloading protocol discussed in zcash/zcash#1113 to support proof generation.