Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: cdna-generator input and fragment-selector output #19

Merged
merged 9 commits into from
Oct 25, 2023

Conversation

balajtimate
Copy link
Collaborator

Description

Refactored the output of priming-site-predictor to match the requirements of cdna-generator
Added fasta headers to the output of fragment-selector

Closes #16
Closes #17

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

Please carefully read these items and tick them off if the statements are true
or do not apply.

  • I have performed a self-review of my own code
  • My code follows the existing coding style, lints and generates no new
    warnings
  • I have added type annotations to all function/method signatures, and I
    have added type annotations for any local variables that are non-trivial,
    potentially ambiguous or might otherwise benefit from explicit typing.
  • I have commented my code in hard-to-understand areas
  • I have added ["Google-style docstrings"] to all new modules, classes,
    methods/functions or updated previously existing ones
  • I have added tests that prove my fix is effective or that my feature
    works
  • New and existing unit tests pass locally with my changes and I have not
    reduced the code coverage relative to the previous state
  • I have updated any sections of the app's documentation that are affected
    by the proposed changes

If for some reason you are unable to tick off all boxes, please leave a
comment explaining the issue you are facing so that we can work on it
together.

@balajtimate balajtimate merged commit 1747d65 into dev Oct 25, 2023
5 of 6 checks passed
@balajtimate balajtimate deleted the fix_cdna_gen branch October 25, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: fragment-selector output is not a fasta file fix: cdna-generator extract info based on headers
1 participant