-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add tax_id parameter #147
Conversation
Co-authored-by: Boris Jurič <[email protected]> Co-authored-by: Alex Kanitz <[email protected]>
* fix pydantic issues * fix: update pydantic version in envs * fix: pin sphinx-rtd-theme into env * fix: update readthedocs config
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #147 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 1078 1108 +30
=========================================
+ Hits 1078 1108 +30 ☔ View full report in Codecov by Sentry. |
…into add_org_param Conflicts: htsinfer/get_library_source.py tests/test_get_library_source.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, getting there. I already approve, because I don't think it will need another review - but please address those comments ;-)
Description
To have better control over the read orientation inference process, allow users to define the organism of the given sample, instead of inferring it. When the organism ID is given, the transcripts file is filtered based on that organism, and the filtered file is used for to infer the orientation.
--org-id
(int) to specify the taxonomy ID of the organism to map the reads againstREADME.md
and.gitignore
get_read_layout.py
and pylint config, remove unused option value 'C0330'.json
method with.model_dump_json
for Pydantic version >2 inhtsinfer.py
(in connection to fix: update Pydantic version #146)Type of change
Checklist
Please carefully read these items and tick them off if the statements are true
or do not apply.
warnings
have added type annotations for any local variables that are non-trivial,
potentially ambiguous or might otherwise benefit from explicit typing.
methods/functions or updated previously existing ones
works
reduced the code coverage relative to the previous state
by the proposed changes
If for some reason you are unable to tick off all boxes, please leave a
comment explaining the issue you are facing so that we can work on it
together.