Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an ImportError w/Blosc on Android #284

Merged

Conversation

danieldjewell
Copy link
Contributor

Android does not have a functioning semaphore system (actually it's
bionic-C that doesn't...). When trying to import numcodecs.blosc on
Android, an ImportError exception was thrown - which was unhandled.

[Description of PR]

TODO:

  • Unit tests and/or doctests in docstrings
  • tox -e py39 passes locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • tox -e docs passes locally
  • GitHub Actions CI passes
  • Test coverage to 100% (Coveralls passes)

Android does not have a functioning semaphore system (actually it's
    bionic-C that doesn't...). When trying to import numcodecs.blosc on
Android, an ImportError exception was thrown - which was unhandled.
@danieldjewell
Copy link
Contributor Author

Just to add: I'm aware of #274 and the discussion in #283. Since that is still a WIP, it seemed like this small fix in the interim would be a good idea.

Copy link
Member

@joshmoore joshmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The additional catch makes sense to me. Ignoring the state of the actions since the failures are unrelated. 👍

Leaving this open briefly for any last minute comments, but then happy to get it out as a quick release.

@joshmoore joshmoore merged commit 98c9e08 into zarr-developers:master Aug 9, 2021
@joshmoore
Copy link
Member

Released as 0.8.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants