Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for import chains in packager2 #3381

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

phillebaba
Copy link
Member

Description

This change adds import chains to the packager2 which were never implemented during the refactor.

Related Issue

Relates to #3180

Checklist before merging

@phillebaba phillebaba requested review from a team as code owners January 7, 2025 14:55
Copy link

netlify bot commented Jan 7, 2025

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 0ffc3aa
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/677d4f77af7ac00008812c9c

@phillebaba phillebaba force-pushed the feature/import-chain branch 2 times, most recently from 0964849 to 38b7bb1 Compare January 7, 2025 15:07
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/internal/packager2/layout/create.go 56.77% <100.00%> (ø)
src/internal/packager2/layout/import.go 13.98% <100.00%> (+3.73%) ⬆️

... and 1 file with indirect coverage changes

@phillebaba phillebaba force-pushed the feature/import-chain branch from 38b7bb1 to 0ffc3aa Compare January 7, 2025 15:59
Copy link
Contributor

@AustinAbro321 AustinAbro321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very elegant solution, nice job

@phillebaba phillebaba added this pull request to the merge queue Jan 8, 2025
Merged via the queue into main with commit 56f62ea Jan 8, 2025
26 checks passed
@phillebaba phillebaba deleted the feature/import-chain branch January 8, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants