refactor: Create structs for each tools command to better isolate commands - cont'd #3357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mands - cont'd Signed-off-by: Maciej Szulik <[email protected]>
✅ Deploy Preview for zarf-docs canceled.
|
AustinAbro321
approved these changes
Dec 20, 2024
Codecov ReportAttention: Patch coverage is
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Continuation of the effort to isolate commands. Followup to #3322 and #3340.
The remaining bit is the root command,
src/pkg/message/message.goandsrc/pkg/logger/logger.go, which I'll need to tackle separately. Since I'm worried about potential impact it might have on all of zarf (the latter two), and on consumers of zarf (the root command). So I will want to coordinate the efforts.Related Issue
Relates to #2773
Checklist before merging