Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow non-interactive package publish with signing key #3348

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

AustinAbro321
Copy link
Contributor

Description

Fixes #3341

Checklist before merging

@AustinAbro321 AustinAbro321 requested review from a team as code owners December 18, 2024 20:35
Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for zarf-docs ready!

Name Link
🔨 Latest commit 4eb15da
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/676332add082b10008c30302
😎 Deploy Preview https://deploy-preview-3348--zarf-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Austin Abro <[email protected]>
@AustinAbro321 AustinAbro321 changed the title fix: allow non-interactive package publish fix: allow non-interactive package publish with signing key Dec 18, 2024
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/cmd/package.go 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/cmd/package.go 0.00% <0.00%> (ø)

Copy link
Contributor

@mkcp mkcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AustinAbro321 AustinAbro321 added this pull request to the merge queue Dec 18, 2024
Merged via the queue into main with commit 54a9396 Dec 18, 2024
38 checks passed
@AustinAbro321 AustinAbro321 deleted the allow-publish-non-interactive-with-no-password branch December 18, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add --confirm flag to zarf package publish
2 participants