test: move lint e2e test to unit test #3334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
✅ Deploy Preview for zarf-docs canceled.
|
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
AustinAbro321
commented
Dec 16, 2024
| @@ -130,14 +130,6 @@ init-package: ## Create the zarf init package (must `brew install coreutils` on | |||
| release-init-package: | |||
| $(ZARF_BIN) package create -o build -a $(ARCH) --set AGENT_IMAGE_TAG=$(AGENT_IMAGE_TAG) --confirm . | |||
|
|
|||
| # INTERNAL: used to build an iron bank version of the init package with an ib version of the registry image | |||
There was a problem hiding this comment.
Shoving this into this PR. We don't do ironbank things anymore in Zarf, no reason to keep this around.
mkcp
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Looks good, added a few comments but no changes requested.
This is definitely outside the scope of the PR, but deleting e2e test 12 highlights to me that these should be named in their order. Add or remove one and all of the other tests are affected. If you agree, would you be interested in scoping out an issue to migrate e2e tests to no longer be numbered?
| @@ -130,14 +130,6 @@ init-package: ## Create the zarf init package (must `brew install coreutils` on | |||
| release-init-package: | |||
| $(ZARF_BIN) package create -o build -a $(ARCH) --set AGENT_IMAGE_TAG=$(AGENT_IMAGE_TAG) --confirm . | |||
|
|
|||
| # INTERNAL: used to build an iron bank version of the init package with an ib version of the registry image | |||
| @@ -128,15 +127,12 @@ func templateZarfObj(zarfObj any, setVariables map[string]string) ([]PackageFind | |||
| }) | |||
| } | |||
| if _, present := setVariables[key]; !present { | |||
| unSetTemplates = true | |||
| findings = append(findings, PackageFinding{ | |||
| Description: fmt.Sprintf("package template %s is not set and won't be evaluated during lint", key), | |||
| } | ||
| cwd, err := os.Getwd() | ||
| require.NoError(t, err) | ||
| // TODO @austinabro321: remove this and parallelize the test once changing the working directory is no longer required |
There was a problem hiding this comment.
Makes sense keeping the scope of changes manageable.
| @@ -93,3 +95,67 @@ func TestFillObjTemplate(t *testing.T) { | |||
| require.ElementsMatch(t, expectedFindings, findings) | |||
| require.Equal(t, expectedComponent, component) | |||
| } | |||
|
|
|||
| func TestLintPackageWithImports(t *testing.T) { | |||
There was a problem hiding this comment.
In an ideal world we would testing more cases which are smaller. But this makes sense as an iterative step in the right direction.
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
lint e2e test should be moved to a unit test for simplicity and to avoid checking output from the cli. Also simplifying the e2e test to focus on flavors, variables, and importing as we have other unit tests already for much for the lint rules.
Checklist before merging