test: change e2e tests to use new log format #3318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Austin Abro <[email protected]>
✅ Deploy Preview for zarf-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
AustinAbro321
changed the title
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
mkcp
approved these changes
Dec 13, 2024
| @@ -30,7 +32,19 @@ type ZarfE2ETest struct { | |||
| ApplianceModeKeep bool | |||
| } | |||
|
|
|||
| var logRegex = regexp.MustCompile(`Saving log file to (?P<logFile>.*?\.log)`) | |||
| // GetLogger returns the default log configuration for the tests. | |||
| func GetLogger(t *testing.T) *slog.Logger { | |||
| suite.NoError(err) | ||
| suite.Contains(stdErr, "Published "+ref) |
| @@ -108,23 +103,6 @@ func TestZarfInit(t *testing.T) { | |||
| _, _, _ = e2e.Kubectl(t, "scale", "deploy", "-n", "zarf", "agent-hook", "--replicas=1") //nolint:errcheck | |||
| } | |||
|
|
|||
| func checkLogForSensitiveState(t *testing.T, logText string, zarfState types.ZarfState) { | |||
There was a problem hiding this comment.
Do we have unit test coverage for zarfState redactions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
change e2e test to use new log format
Related Issue
Fixes #3304
Checklist before merging