Test checksums from package create #3099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillebaba
force-pushed
the
test/package-create-checksum
branch
from
5293be6 to
510655f
Compare
❌ Deploy Preview for zarf-docs failed. Why did it fail? →
|
✅ Deploy Preview for zarf-docs canceled.
|
Codecov ReportAttention: Patch coverage is
|
phillebaba
force-pushed
the
test/package-create-checksum
branch
10 times, most recently
from
008fe86 to
13a08e3
Compare
|
I have removed checking checksums for packages with Git repositories as they will always produce components with different shasums due to Git modifying the metadata. I have also removed checking the checksum of the SBOM as it will also produce new results on each build. Even if we don't check everything in this test it is a good step forward to making sure a PR does not change how a package is built in unexpected ways. |
Signed-off-by: Philip Laine <[email protected]>
phillebaba
force-pushed
the
test/package-create-checksum
branch
from
13a08e3 to
06db099
Compare
AustinAbro321
approved these changes
Oct 16, 2024
mjnagel
pushed a commit
to mjnagel/zarf
that referenced
this pull request
Oct 21, 2024
Signed-off-by: Philip Laine <[email protected]> Signed-off-by: Micah Nagel <[email protected]>
Jneville0815
pushed a commit
to radiusmethod/zarf
that referenced
this pull request
Dec 12, 2024
Signed-off-by: Philip Laine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds a new workflow which verifies the checksums of all the examples. The purpose of this is to avoid regression related to package creation.
Related Issue
Relates to #2969
Checklist before merging