POC: attribute redactions with slog #3085
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a POC of how attribute redactions might look with slog.
This changes two places where Zarf prints. The first is in the function
debugPrintZarfState
. Here is an example of what that function would print now.The second is in the function
PrintCredentialUpdates
which now may look likeWhile this is clean in that any time any of the objects are printed we don't have to remember to redact, it does force us to implement LogValue functions on every object that includes a ZarfPassword sub object. This will also require us to update the object functions when we want something new on them
There is a lot of noise in the PR since I changed types. Relevant files are:
Checklist before merging