Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat): Remove progress bar #3067

Closed
wants to merge 4 commits into from

Conversation

schristoff
Copy link
Contributor

This could help with #2104

@schristoff schristoff requested review from a team as code owners October 3, 2024 17:15
Copy link

netlify bot commented Oct 3, 2024

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit c0d8fa4
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/66ffadbfbfca460009d4f3fa

Copy link

codecov bot commented Oct 3, 2024

Signed-off-by: schristoff <[email protected]>
Signed-off-by: schristoff <[email protected]>
Signed-off-by: schristoff <[email protected]>
@AustinAbro321
Copy link
Contributor

How would you feel about adding a message.info like we do in the new mirror? I know some users have many large images / have 100s of images. IMO we'll want to give some indication that the system is progressing

message.Infof("Pushing image %s", name)

@schristoff
Copy link
Contributor Author

closing due to internal discussion

@schristoff schristoff closed this Oct 7, 2024
@schristoff schristoff deleted the schristoff_2104 branch October 7, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants