Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add flag to force push repositories to gitea during deployment #3023

Closed

Conversation

Jneville0815
Copy link

Description

Add flag to force push repositories to gitea during deployment. Not sure if any tests need to be created or updated for this change?
...

Related Issue

Fixes #1410

Relates to #1410

Checklist before merging

@Jneville0815 Jneville0815 requested review from a team as code owners September 24, 2024 17:33
Copy link

netlify bot commented Sep 24, 2024

Deploy Preview for zarf-docs ready!

Name Link
🔨 Latest commit 75340a8
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/675ad18961ec8a000810e6f9
😎 Deploy Preview https://deploy-preview-3023--zarf-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Jneville0815 Jneville0815 force-pushed the feature/force-push-repos branch from 0aabddd to dcae8e4 Compare September 24, 2024 17:34
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/internal/packager2/mirror.go 0.00% 4 Missing ⚠️
src/cmd/package.go 0.00% 2 Missing ⚠️
src/internal/git/repository.go 0.00% 2 Missing ⚠️
src/pkg/packager/deploy.go 0.00% 2 Missing ⚠️
Files with missing lines Coverage Δ
src/cmd/package.go 0.00% <0.00%> (ø)
src/internal/git/repository.go 16.77% <0.00%> (-0.11%) ⬇️
src/pkg/packager/deploy.go 9.03% <0.00%> (ø)
src/internal/packager2/mirror.go 0.00% <0.00%> (ø)

@phillebaba phillebaba changed the title Add flag to force push repositories to gitea during deployment feat: add flag to force push repositories to gitea during deployment Oct 1, 2024
@phillebaba
Copy link
Member

@Jneville0815 could you generate docs and then we can merge.

@Jneville0815
Copy link
Author

@phillebaba done

@Jneville0815 Jneville0815 force-pushed the feature/force-push-repos branch 2 times, most recently from 0c74e82 to f152c67 Compare October 2, 2024 12:38
@Jneville0815
Copy link
Author

@phillebaba any update on this?

@@ -551,6 +552,7 @@ func bindDeployFlags(v *viper.Viper) {
deployFlags.StringVar(&pkgConfig.PkgOpts.Shasum, "shasum", v.GetString(common.VPkgDeployShasum), lang.CmdPackageDeployFlagShasum)
deployFlags.StringVar(&pkgConfig.PkgOpts.SGetKeyPath, "sget", v.GetString(common.VPkgDeploySget), lang.CmdPackageDeployFlagSget)
deployFlags.BoolVar(&pkgConfig.PkgOpts.SkipSignatureValidation, "skip-signature-validation", false, lang.CmdPackageFlagSkipSignatureValidation)
deployFlags.BoolVar(&pkgConfig.DeployOpts.ForcePushRepos, "force-push-repos", false, lang.CmdPackageForcePushRepos)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also has to be added to the mirror command flags.

@phillebaba
Copy link
Member

@Jneville0815 sorry for the delay. KubeCon and some other things took up a lot of time. I did some thinking initially about making force true all the time to reduce the configuration exposed to the end user, but realized eventually that this is probably not a good idea.

So to move forward with this PR we need to do two things. First of all rebase the branch to get things to merge. Second of all add the flag to the mirror command flags. After that we should be good to merge.

@Jneville0815 Jneville0815 force-pushed the feature/force-push-repos branch 2 times, most recently from d22fd62 to c4b7304 Compare December 12, 2024 12:03
@Jneville0815 Jneville0815 force-pushed the feature/force-push-repos branch from c4b7304 to 75340a8 Compare December 12, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support force pushing to repositories using the Refspec format
2 participants