-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add flag to force push repositories to gitea during deployment #3023
Conversation
✅ Deploy Preview for zarf-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
0aabddd
to
dcae8e4
Compare
Codecov ReportAttention: Patch coverage is
|
@Jneville0815 could you generate docs and then we can merge. |
@phillebaba done |
0c74e82
to
f152c67
Compare
@phillebaba any update on this? |
src/cmd/package.go
Outdated
@@ -551,6 +552,7 @@ func bindDeployFlags(v *viper.Viper) { | |||
deployFlags.StringVar(&pkgConfig.PkgOpts.Shasum, "shasum", v.GetString(common.VPkgDeployShasum), lang.CmdPackageDeployFlagShasum) | |||
deployFlags.StringVar(&pkgConfig.PkgOpts.SGetKeyPath, "sget", v.GetString(common.VPkgDeploySget), lang.CmdPackageDeployFlagSget) | |||
deployFlags.BoolVar(&pkgConfig.PkgOpts.SkipSignatureValidation, "skip-signature-validation", false, lang.CmdPackageFlagSkipSignatureValidation) | |||
deployFlags.BoolVar(&pkgConfig.DeployOpts.ForcePushRepos, "force-push-repos", false, lang.CmdPackageForcePushRepos) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also has to be added to the mirror command flags.
@Jneville0815 sorry for the delay. KubeCon and some other things took up a lot of time. I did some thinking initially about making force true all the time to reduce the configuration exposed to the end user, but realized eventually that this is probably not a good idea. So to move forward with this PR we need to do two things. First of all rebase the branch to get things to merge. Second of all add the flag to the mirror command flags. After that we should be good to merge. |
d22fd62
to
c4b7304
Compare
c4b7304
to
75340a8
Compare
Description
Add flag to force push repositories to gitea during deployment. Not sure if any tests need to be created or updated for this change?
...
Related Issue
Fixes #1410
Relates to #1410
Checklist before merging