Replace github.com/avast/retry-go/v4 library with k8s counterparts #3019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for zarf-docs canceled.
|
soltysh
force-pushed
the
k8s_retry
branch
3 times, most recently
from
0751dfe to
5aebe86
Compare
Trying to limit the potential dependencies. We already rely on k8s.io/client-go which retry logic has very similar interfac. Signed-off-by: Maciej Szulik <[email protected]>
…llUntil* Trying to limit the potential dependencies. We already rely on k8s/apimachinery which has very similar wait.PollUntil* functionality. Signed-off-by: Maciej Szulik <[email protected]>
Signed-off-by: Maciej Szulik <[email protected]>
AustinAbro321
approved these changes
Sep 23, 2024
|
This will be added when contexts are able to be used. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Trying to limit the potential dependencies. We already rely on k8s.io/client-go and k8s.io/apimachinery which have
retry.OnErrororwait.PollUntil*methods which can achieve identical results.Related Issue
NONE
Checklist before merging