Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: create #3005

Closed
wants to merge 1 commit into from
Closed

refactor: create #3005

wants to merge 1 commit into from

Conversation

phillebaba
Copy link
Member

Description

Refactors create command.

Related Issue

Relates to #2969

Checklist before merging

Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit bf9cbb4
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/66f06e10cbbc860008d8d142

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 58 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/internal/packager2/create.go 0.00% 56 Missing ⚠️
src/cmd/package.go 0.00% 2 Missing ⚠️
Files with missing lines Coverage Δ
src/cmd/package.go 0.00% <0.00%> (ø)
src/internal/packager2/create.go 0.00% <0.00%> (ø)

@phillebaba phillebaba marked this pull request as ready for review September 18, 2024 15:46
@phillebaba phillebaba requested review from a team as code owners September 18, 2024 15:46
"github.com/zarf-dev/zarf/src/pkg/utils"
"github.com/zarf-dev/zarf/src/types"
)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CreateOpts should go here, no?

AustinAbro321
AustinAbro321 previously approved these changes Sep 19, 2024
Copy link
Contributor

@AustinAbro321 AustinAbro321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, would love to see createOpts no longer passed into the package creator interface. But that should definitely be separate from this PR

Signed-off-by: Philip Laine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants