Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: workflow to check that go mod tidy is run #2963

Merged
merged 10 commits into from
Sep 20, 2024
Merged

chore: workflow to check that go mod tidy is run #2963

merged 10 commits into from
Sep 20, 2024

Conversation

AustinAbro321
Copy link
Contributor

@AustinAbro321 AustinAbro321 commented Sep 3, 2024 •
edited
Loading

Description

Adds a workflow to check that go mod tidy is run

Related Issue

Fixes #2961

Checklist before merging

@AustinAbro321
check docs and schema
9b0a81a 
Signed-off-by: Austin Abro <[email protected]>
@netlify Netlify
Copy link

netlify bot commented Sep 3, 2024 •
edited
Loading

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit baac7a2
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/66d9c3425e24b30008b5ccbc

@codecov Codecov
Copy link

codecov bot commented Sep 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

@AustinAbro321
test go mod
d6bbe90 
Signed-off-by: Austin Abro <[email protected]>
@AustinAbro321 AustinAbro321 changed the title ci: check for go mod changes ci: pre-commit hook for go mod changes Sep 3, 2024
@AustinAbro321 AustinAbro321 changed the title ci: pre-commit hook for go mod changes ci: pre-commit hook go mod tidy Sep 3, 2024
@AustinAbro321 AustinAbro321 marked this pull request as ready for review September 3, 2024 15:52
@AustinAbro321 AustinAbro321 requested review from a team as code owners September 3, 2024 15:52
@AustinAbro321 AustinAbro321 changed the title ci: pre-commit hook go mod tidy chore: pre-commit hook go mod tidy Sep 4, 2024
@AustinAbro321
test go mod
f9c230c 
Signed-off-by: Austin Abro <[email protected]>
@AustinAbro321
try again
93e1648 
Signed-off-by: Austin Abro <[email protected]>
@AustinAbro321
try out without make
d90a77f 
Signed-off-by: Austin Abro <[email protected]>
@AustinAbro321
go mod tidy
499331c 
Signed-off-by: Austin Abro <[email protected]>
@AustinAbro321
merge
200949c 
Signed-off-by: Austin Abro <[email protected]>
@AustinAbro321
tryout workflow
438e1fe 
Signed-off-by: Austin Abro <[email protected]>
@AustinAbro321
main go mod
3d2be6a 
Signed-off-by: Austin Abro <[email protected]>
@AustinAbro321
test go mod
baac7a2 
Signed-off-by: Austin Abro <[email protected]>
@AustinAbro321 AustinAbro321 changed the title chore: pre-commit hook go mod tidy chore: workflow to check that go mod tidy is run Sep 5, 2024
@AustinAbro321 AustinAbro321 added this pull request to the merge queue Sep 20, 2024
Merged via the queue into main with commit 75da156 Sep 20, 2024
30 checks passed
@AustinAbro321 AustinAbro321 deleted the check-go-mod branch September 20, 2024 13:15
ittacco pushed a commit to ittacco/zarf that referenced this pull request Nov 9, 2024
@AustinAbro321 @ittacco
chore: workflow to check that go mod tidy is run (zarf-dev#2963)
c6d0654 
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: ittacco <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillebaba phillebaba phillebaba approved these changes

Assignees
No one assigned
Labels
ready-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add workflow to check if running go mod tidy changes go mod file
2 participants
@AustinAbro321 @phillebaba