fix: import paths to avoid cycle #2861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillebaba
force-pushed
the
fix/import
branch
2 times, most recently
from
3457c2e to
850cfd8
Compare
schristoff
previously approved these changes
Aug 8, 2024
Signed-off-by: Philip Laine <[email protected]>
schristoff
approved these changes
Aug 8, 2024
schristoff
approved these changes
Aug 8, 2024
mjnagel
referenced
this pull request
in defenseunicorns/uds-core
Aug 9, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | ghcr.io/zarf-dev/packages/init | minor | `v0.37.0` -> `v0.38.1` | | [zarf-dev/zarf](https://togithub.com/zarf-dev/zarf) | minor | `v0.37.0` -> `v0.38.1` | --- ### Release Notes <details> <summary>zarf-dev/zarf (zarf-dev/zarf)</summary> ### [`v0.38.1`](https://togithub.com/zarf-dev/zarf/compare/v0.38.0...v0.38.1) [Compare Source](https://togithub.com/zarf-dev/zarf/compare/v0.38.0...v0.38.1) ### [`v0.38.0`](https://togithub.com/zarf-dev/zarf/releases/tag/v0.38.0) [Compare Source](https://togithub.com/zarf-dev/zarf/compare/v0.37.0...v0.38.0) #### What's Changed - refactor: utilize invopop comment feature by [@​AustinAbro321](https://togithub.com/AustinAbro321) in [https://github.com/zarf-dev/zarf/pull/2781](https://togithub.com/zarf-dev/zarf/pull/2781) - fix: detect invalid helm release names by [@​jamestexas](https://togithub.com/jamestexas) in [https://github.com/zarf-dev/zarf/pull/2784](https://togithub.com/zarf-dev/zarf/pull/2784) - refactor: move gitea code to separate package by [@​phillebaba](https://togithub.com/phillebaba) in [https://github.com/zarf-dev/zarf/pull/2785](https://togithub.com/zarf-dev/zarf/pull/2785) - fix: add dependabot and disable renovate features by [@​AustinAbro321](https://togithub.com/AustinAbro321) in [https://github.com/zarf-dev/zarf/pull/2789](https://togithub.com/zarf-dev/zarf/pull/2789) - chore(deps): bump github/codeql-action from 3.24.0 to 3.25.15 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/zarf-dev/zarf/pull/2792](https://togithub.com/zarf-dev/zarf/pull/2792) - chore(deps): bump actions/upload-artifact from 4.3.1 to 4.3.4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/zarf-dev/zarf/pull/2791](https://togithub.com/zarf-dev/zarf/pull/2791) - chore(deps): bump golangci/golangci-lint-action from 6.0.1 to 6.1.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/zarf-dev/zarf/pull/2793](https://togithub.com/zarf-dev/zarf/pull/2793) - chore(deps): bump docker/login-action from 3.0.0 to 3.3.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/zarf-dev/zarf/pull/2794](https://togithub.com/zarf-dev/zarf/pull/2794) - chore(deps): bump ossf/scorecard-action from 2.3.1 to 2.4.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/zarf-dev/zarf/pull/2795](https://togithub.com/zarf-dev/zarf/pull/2795) - chore(deps): bump k8s.io/component-base from 0.30.0 to 0.30.3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/zarf-dev/zarf/pull/2798](https://togithub.com/zarf-dev/zarf/pull/2798) - ci: remove unneeded cve checking by [@​AustinAbro321](https://togithub.com/AustinAbro321) in [https://github.com/zarf-dev/zarf/pull/2802](https://togithub.com/zarf-dev/zarf/pull/2802) - chore(deps): bump github.com/mikefarah/yq/v4 from 4.43.1 to 4.44.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/zarf-dev/zarf/pull/2799](https://togithub.com/zarf-dev/zarf/pull/2799) - chore(deps): bump codecov/codecov-action from 4.4.1 to 4.5.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/zarf-dev/zarf/pull/2808](https://togithub.com/zarf-dev/zarf/pull/2808) - chore(deps): bump actions/create-github-app-token from 1.9.0 to 1.10.3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/zarf-dev/zarf/pull/2809](https://togithub.com/zarf-dev/zarf/pull/2809) - chore(deps): bump actions/download-artifact from 4.1.2 to 4.1.8 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/zarf-dev/zarf/pull/2810](https://togithub.com/zarf-dev/zarf/pull/2810) - chore(deps): bump actions/checkout from 4.1.1 to 4.1.7 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/zarf-dev/zarf/pull/2807](https://togithub.com/zarf-dev/zarf/pull/2807) - chore(deps): bump golang.org/x/crypto from 0.24.0 to 0.25.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/zarf-dev/zarf/pull/2813](https://togithub.com/zarf-dev/zarf/pull/2813) - chore(deps): bump github.com/goccy/go-yaml from 1.11.3 to 1.12.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/zarf-dev/zarf/pull/2811](https://togithub.com/zarf-dev/zarf/pull/2811) - chore(deps): bump aws-actions/configure-aws-credentials from 4.0.1 to 4.0.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/zarf-dev/zarf/pull/2806](https://togithub.com/zarf-dev/zarf/pull/2806) - fix: resolve CVE-2024-41110 by [@​AustinAbro321](https://togithub.com/AustinAbro321) in [https://github.com/zarf-dev/zarf/pull/2815](https://togithub.com/zarf-dev/zarf/pull/2815) - refactor: git package by [@​phillebaba](https://togithub.com/phillebaba) in [https://github.com/zarf-dev/zarf/pull/2790](https://togithub.com/zarf-dev/zarf/pull/2790) - ci: better named gh jobs by [@​AustinAbro321](https://togithub.com/AustinAbro321) in [https://github.com/zarf-dev/zarf/pull/2816](https://togithub.com/zarf-dev/zarf/pull/2816) - chore(deps): bump actions/dependency-review-action from 4.1.3 to 4.3.4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/zarf-dev/zarf/pull/2822](https://togithub.com/zarf-dev/zarf/pull/2822) - chore(deps): bump actions/setup-node from 4.0.2 to 4.0.3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/zarf-dev/zarf/pull/2821](https://togithub.com/zarf-dev/zarf/pull/2821) - chore: move context.TODO to context.Background() (4) by [@​schristoff](https://togithub.com/schristoff) in [https://github.com/zarf-dev/zarf/pull/2749](https://togithub.com/zarf-dev/zarf/pull/2749) - chore(deps): bump github.com/sigstore/sigstore/pkg/signature/kms/hashivault from 1.8.1 to 1.8.7 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/zarf-dev/zarf/pull/2800](https://togithub.com/zarf-dev/zarf/pull/2800) - chore: turn down codecov by [@​schristoff](https://togithub.com/schristoff) in [https://github.com/zarf-dev/zarf/pull/2823](https://togithub.com/zarf-dev/zarf/pull/2823) - chore(deps): bump github.com/sigstore/sigstore/pkg/signature/kms/gcp from 1.8.1 to 1.8.7 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/zarf-dev/zarf/pull/2812](https://togithub.com/zarf-dev/zarf/pull/2812) - refactor: move and test HasImages by [@​phillebaba](https://togithub.com/phillebaba) in [https://github.com/zarf-dev/zarf/pull/2831](https://togithub.com/zarf-dev/zarf/pull/2831) - fix: disk pressure flakes by [@​AustinAbro321](https://togithub.com/AustinAbro321) in [https://github.com/zarf-dev/zarf/pull/2832](https://togithub.com/zarf-dev/zarf/pull/2832) - chore(deps): bump actions/upload-artifact from 4.3.4 to 4.3.5 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/zarf-dev/zarf/pull/2834](https://togithub.com/zarf-dev/zarf/pull/2834) - refactor: change isInternal variables to functions by [@​AustinAbro321](https://togithub.com/AustinAbro321) in [https://github.com/zarf-dev/zarf/pull/2768](https://togithub.com/zarf-dev/zarf/pull/2768) - chore: update obsolete versions by [@​AustinAbro321](https://togithub.com/AustinAbro321) in [https://github.com/zarf-dev/zarf/pull/2830](https://togithub.com/zarf-dev/zarf/pull/2830) - refactor: init zarf state by [@​AustinAbro321](https://togithub.com/AustinAbro321) in [https://github.com/zarf-dev/zarf/pull/2833](https://togithub.com/zarf-dev/zarf/pull/2833) - fix: ignore config file not found errors by [@​AustinAbro321](https://togithub.com/AustinAbro321) in [https://github.com/zarf-dev/zarf/pull/2838](https://togithub.com/zarf-dev/zarf/pull/2838) - fix: override tunnel details with user-provided settings by [@​chaospuppy](https://togithub.com/chaospuppy) in [https://github.com/zarf-dev/zarf/pull/2841](https://togithub.com/zarf-dev/zarf/pull/2841) - refactor: move package generation to a local variable by [@​phillebaba](https://togithub.com/phillebaba) in [https://github.com/zarf-dev/zarf/pull/2835](https://togithub.com/zarf-dev/zarf/pull/2835) - feat: move ZarfPackageConfig to it's own api-versioned package by [@​AustinAbro321](https://togithub.com/AustinAbro321) in [https://github.com/zarf-dev/zarf/pull/2801](https://togithub.com/zarf-dev/zarf/pull/2801) - refactor: replace debug logs with returning errors by [@​phillebaba](https://togithub.com/phillebaba) in [https://github.com/zarf-dev/zarf/pull/2777](https://togithub.com/zarf-dev/zarf/pull/2777) - refactor: proxy and add tests by [@​phillebaba](https://togithub.com/phillebaba) in [https://github.com/zarf-dev/zarf/pull/2843](https://togithub.com/zarf-dev/zarf/pull/2843) - chore(deps): bump github/codeql-action from 3.25.15 to 3.26.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/zarf-dev/zarf/pull/2848](https://togithub.com/zarf-dev/zarf/pull/2848) - chore(deps): bump actions/upload-artifact from 4.3.5 to 4.3.6 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/zarf-dev/zarf/pull/2847](https://togithub.com/zarf-dev/zarf/pull/2847) - test: add tests for FindImages by [@​phillebaba](https://togithub.com/phillebaba) in [https://github.com/zarf-dev/zarf/pull/2850](https://togithub.com/zarf-dev/zarf/pull/2850) - test: unit test index sha by [@​AustinAbro321](https://togithub.com/AustinAbro321) in [https://github.com/zarf-dev/zarf/pull/2844](https://togithub.com/zarf-dev/zarf/pull/2844) - chore(deps): bump github.com/spf13/viper from 1.18.2 to 1.19.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/zarf-dev/zarf/pull/2828](https://togithub.com/zarf-dev/zarf/pull/2828) - chore: update dos games by [@​AustinAbro321](https://togithub.com/AustinAbro321) in [https://github.com/zarf-dev/zarf/pull/2845](https://togithub.com/zarf-dev/zarf/pull/2845) - chore(deps): bump sigs.k8s.io/kustomize/api from 0.16.0 to 0.17.3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/zarf-dev/zarf/pull/2826](https://togithub.com/zarf-dev/zarf/pull/2826) - chore(deps): bump github.com/pterm/pterm from 0.12.78 to 0.12.79 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/zarf-dev/zarf/pull/2854](https://togithub.com/zarf-dev/zarf/pull/2854) - fix: install grype during release by [@​phillebaba](https://togithub.com/phillebaba) in [https://github.com/zarf-dev/zarf/pull/2857](https://togithub.com/zarf-dev/zarf/pull/2857) - fix: import paths to avoid cycle by [@​phillebaba](https://togithub.com/phillebaba) in [https://github.com/zarf-dev/zarf/pull/2861](https://togithub.com/zarf-dev/zarf/pull/2861) #### New Contributors - [@​jamestexas](https://togithub.com/jamestexas) made their first contribution in [https://github.com/zarf-dev/zarf/pull/2784](https://togithub.com/zarf-dev/zarf/pull/2784) **Full Changelog**: zarf-dev/zarf@v0.37.0...v0.38.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/defenseunicorns/uds-core). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM4LjIwLjEiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes any circular dependency between api and other packages.
Related Issue
N/A
Checklist before merging