Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move package state to local variable #2836

Closed
wants to merge 1 commit into from

Conversation

phillebaba
Copy link
Member

Description

This removes the Zarf state as a property in the packager struct. Instead it is loaded in functions that needs it and passed as a argument.

Related Issue

Relates to #2709

Checklist before merging

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 69 lines in your changes missing coverage. Please review.

Files Patch % Lines
src/internal/packager/template/template.go 0.00% 31 Missing ⚠️
src/pkg/packager/deploy.go 0.00% 25 Missing ⚠️
src/pkg/packager/mirror.go 0.00% 10 Missing ⚠️
src/internal/packager/helm/zarf.go 0.00% 1 Missing ⚠️
src/pkg/packager/prepare.go 0.00% 1 Missing ⚠️
src/pkg/packager/remove.go 0.00% 1 Missing ⚠️
Files Coverage Δ
src/pkg/packager/common.go 52.52% <ø> (ø)
src/internal/packager/helm/zarf.go 0.00% <0.00%> (ø)
src/pkg/packager/prepare.go 0.00% <0.00%> (ø)
src/pkg/packager/remove.go 0.00% <0.00%> (ø)
src/pkg/packager/mirror.go 0.00% <0.00%> (ø)
src/pkg/packager/deploy.go 4.29% <0.00%> (+0.01%) ⬆️
src/internal/packager/template/template.go 8.06% <0.00%> (+0.48%) ⬆️

@phillebaba phillebaba force-pushed the remove/global-state branch from 342f3d1 to 52bd248 Compare August 5, 2024 15:12
@phillebaba phillebaba force-pushed the remove/global-state branch from 52bd248 to 9217e8f Compare August 6, 2024 09:21
@phillebaba phillebaba closed this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant