refactor: add error to packager set paths #2753
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AustinAbro321 I did this PR to see what you think first. Personally I do not like to silently error. If we are going to do so we should probably make this more apparent and explain why we fail silently. |
Signed-off-by: Philip Laine <[email protected]>
phillebaba
force-pushed
the
refactor/set-paths
branch
from
85eafeb to
4a69fbd
Compare
|
I was wrong about this change. The default case is ignored when for example when the path is a manifest. I still feel like we should test for that and do nothing to catch any future problem however. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change removes the debug log and replaces it with an error when a package path is of unknown format.
Related Issue
Relates to #2576
Checklist before merging