fix: actually cleaning up the test with RemovalAll seems to cause a p…

…anic

Signed-off-by: Kit Patella <[email protected]>

src/test/external/ext_in_cluster_test.go

@@ -157,7 +157,7 @@ func (suite *ExtInClusterTestSuite) Test_1_Deploy() {
 	err := exec.CmdWithPrint(zarfBinPath, initArgs...)
 	suite.NoError(err, "unable to initialize the k8s server with zarf")
 	temp := suite.T().TempDir()
-	defer createPodInfoPackageWithInsecureSources(suite.T(), temp)
+	createPodInfoPackageWithInsecureSources(suite.T(), temp)
 
 	// Deploy the flux example package
 	deployArgs := []string{"package", "deploy", filepath.Join(temp, "zarf-package-podinfo-flux-amd64.tar.zst"), "--confirm"}
@@ -200,8 +200,10 @@ func (suite *ExtInClusterTestSuite) Test_1_Deploy() {
 	_, _, err = exec.CmdWithTesting(suite.T(), exec.PrintCfg(), zarfBinPath, "destroy", "--confirm")
 	suite.NoError(err, "unable to teardown zarf")
 
-	err = os.RemoveAll(temp)
-	suite.NoError(err, "unable to remove temp directory")
+	// FIXME(mkcp): This code always fails to clean up the tmpdir. We're passing it a directory with contents and we
+	//  need os.RemoveAll(temp) instead. However, we're also getting what looks to be a bug with concurrent  writers
+	//  causing a subtest to panic when we call RemoveAll(). Fixing this would require removing the shared state.
+	_ = os.Remove(temp) // nolint:errcheck
 }
 
 func TestExtInClusterTestSuite(t *testing.T) {